Re: [PULL 20/20] tracing: install trace events file only if necessary

[Carlos Santos]

On Thu, Apr 20, 2023 at 9:10 AM Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> From: Carlos Santos <casantos@redhat.com>
>
> It is not useful when configuring with --enable-trace-backends=nop.
>
> Signed-off-by: Carlos Santos <casantos@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> Message-Id: <20230408010410.281263-1-casantos@redhat.com>
> ---
>  trace/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/trace/meson.build b/trace/meson.build
> index 8e80be895c..30b1d942eb 100644
> --- a/trace/meson.build
> +++ b/trace/meson.build
> @@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all',
>                                   input: trace_events_files,
>                                   command: [ 'cat', '@INPUT@' ],
>                                   capture: true,
> -                                 install: true,
> +                                 install: get_option('trace_backends') != [ 
> 'nop' ],
>                                   install_dir: qemu_datadir)
>
>  if 'ust' in get_option('trace_backends')
> --
> 2.39.2
>

Hello,

I still don't see this in the master branch. Is there something
preventing it from being applied?

-- 
Carlos Santos
Senior Software Maintenance Engineer
Red Hat
casantos@redhat.com    T: +55-11-3534-6186