[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 12/14] scsi: remove outdated AioContext lock comment
From: |
Stefan Hajnoczi |
Subject: |
[PATCH v2 12/14] scsi: remove outdated AioContext lock comment |
Date: |
Tue, 5 Dec 2023 13:20:09 -0500 |
The SCSI subsystem no longer uses the AioContext lock. Request
processing runs exclusively in the BlockBackend's AioContext since
"scsi: only access SCSIDevice->requests from one thread" and hence the
lock is unnecessary.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
hw/scsi/scsi-disk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 61be3d395a..2e7e1e9a1c 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -355,7 +355,6 @@ done:
scsi_req_unref(&r->req);
}
-/* Called with AioContext lock held */
static void scsi_dma_complete(void *opaque, int ret)
{
SCSIDiskReq *r = (SCSIDiskReq *)opaque;
--
2.43.0
- Re: [PATCH v2 06/14] block: remove AioContext locking, (continued)
[PATCH v2 08/14] scsi: remove AioContext locking, Stefan Hajnoczi, 2023/12/05
[PATCH v2 05/14] graph-lock: remove AioContext locking, Stefan Hajnoczi, 2023/12/05
[PATCH v2 10/14] aio: remove aio_context_acquire()/aio_context_release() API, Stefan Hajnoczi, 2023/12/05
[PATCH v2 09/14] aio-wait: draw equivalence between AIO_WAIT_WHILE() and AIO_WAIT_WHILE_UNLOCKED(), Stefan Hajnoczi, 2023/12/05
[PATCH v2 12/14] scsi: remove outdated AioContext lock comment,
Stefan Hajnoczi <=
[PATCH v2 13/14] job: remove outdated AioContext locking comments, Stefan Hajnoczi, 2023/12/05
[PATCH v2 11/14] docs: remove AioContext lock from IOThread docs, Stefan Hajnoczi, 2023/12/05
[PATCH v2 14/14] block: remove outdated AioContext locking comments, Stefan Hajnoczi, 2023/12/05
Re: [PATCH v2 00/14] aio: remove AioContext lock, Kevin Wolf, 2023/12/19