Re: [RFC PATCH 01/11] acpi: hmp/qmp: Add hmp/qmp support for system_sleep

[Philippe Mathieu-Daudé]

Hi Annie,

On 5/12/23 01:23, Annie Li wrote:
> Following hmp/qmp commands are implemented for pressing virtual
> sleep button,
>
> hmp: system_sleep
> qmp: { "execute": "system_sleep" }
>
> These commands put the guest into suspend or other power states
> depending on the power settings inside the guest.
>
> Signed-off-by: Annie Li <annie.li@oracle.com>
> ---
>   hmp-commands.hx            | 14 ++++++++++++++
>   hw/core/machine-hmp-cmds.c |  5 +++++
>   hw/core/machine-qmp-cmds.c |  9 +++++++++
>   include/monitor/hmp.h      |  1 +
>   qapi/machine.json          | 18 ++++++++++++++++++
>   qapi/pragma.json           |  1 +
>   6 files changed, 48 insertions(+)


> index b6d634b30d..3ac69df92f 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -297,6 +297,24 @@
>   ##
>   { 'command': 'system_reset' }
>   
> +##
> +# @system_sleep:

@since 9.0

> +#
> +# Requests that a guest perform a ACPI sleep transition by pushing a virtual
> +# sleep button.
> +#
> +# Notes: A guest may or may not respond to this command. This command
> +#        returning does not indicate that a guest has accepted the request
> +#        or that it has gone to sleep.
> +#
> +# Example:
> +#
> +# -> { "execute": "system_sleep" }
> +# <- { "return": {} }
> +#
> +##
> +{ 'command': 'system_sleep' }

Do we want a 'mode' argument, starting here with control_method?

> +
>   ##
>   # @system_powerdown:
>   #