Re: [PATCH v3 13/70] i386: Introduce tdx-guest object

[Xiaoyao Li]

On 12/1/2023 6:52 PM, Markus Armbruster wrote:
> Xiaoyao Li <xiaoyao.li@intel.com> writes:
>
> > Introduce tdx-guest object which implements the interface of
> > CONFIDENTIAL_GUEST_SUPPORT, and will be used to create TDX VMs (TDs) by
> >
> >    qemu -machine ...,confidential-guest-support=tdx0    \
> >         -object tdx-guest,id=tdx0
> >
> > It has only one member 'attributes' with fixed value 0 and not
> > configurable so far.
> >
> > Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> > Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> > Acked-by: Markus Armbruster <armbru@redhat.com>
>
> [...]
>
> > diff --git a/qapi/qom.json b/qapi/qom.json
> > index c53ef978ff7e..8e08257dac2f 100644
> > --- a/qapi/qom.json
> > +++ b/qapi/qom.json
> > @@ -878,6 +878,16 @@
> >               'reduced-phys-bits': 'uint32',
> >               '*kernel-hashes': 'bool' } }
> >   
> > +##
> > +# @TdxGuestProperties:
> > +#
> > +# Properties for tdx-guest objects.
> > +#
> > +# Since: 8.2
>
> Going to be 9.0.

will update it and all others.

(I left it as 8.2 because I was not sure next version is 8.3 or 9.0)

> > +##
> > +{ 'struct': 'TdxGuestProperties',
> > +  'data': { }}
> > +
> >   ##
> >   # @ThreadContextProperties:
> >   #
> > @@ -956,6 +966,7 @@
> >       'sev-guest',
> >       'thread-context',
> >       's390-pv-guest',
> > +    'tdx-guest',
> >       'throttle-group',
> >       'tls-creds-anon',
> >       'tls-creds-psk',
> > @@ -1022,6 +1033,7 @@
> >         'secret_keyring':             { 'type': 'SecretKeyringProperties',
> >                                         'if': 'CONFIG_SECRET_KEYRING' },
> >         'sev-guest':                  'SevGuestProperties',
> > +      'tdx-guest':                  'TdxGuestProperties',
> >         'thread-context':             'ThreadContextProperties',
> >         'throttle-group':             'ThrottleGroupProperties',
> >         'tls-creds-anon':             'TlsCredsAnonProperties',
>
> [...]