Re: [PATCH v6 0/4] compare machine type compat_props

[Philippe Mathieu-Daudé]

Hi Maksim,

On 8/11/23 16:38, Maksim Davydov wrote:
> This script can be used to choose the best machine type in the
> appropriate cases. Also we have to check compat_props of the old MT
> after changes to be sure that they haven't broken old the MT. For
> example, pc_compat_3_1 of pc-q35-3.1 has Icelake-Client which was
> removed.

> Maksim Davydov (4):
>    qom: add default value
>    qmp: add dump machine type compatible properties
>    python: add binary
>    scripts: add script to compare compatible properties
>
>   hw/core/machine-qmp-cmds.c     |  23 +-
>   python/qemu/machine/machine.py |   5 +
>   qapi/machine.json              |  54 +++-
>   qom/qom-qmp-cmds.c             |   1 +
>   scripts/compare_mt.py          | 484 +++++++++++++++++++++++++++++++++

"compare_machine_types.py" name is more meaningful.

>   tests/qtest/fuzz/qos_fuzz.c    |   2 +-
>   6 files changed, 565 insertions(+), 4 deletions(-)
>   create mode 100755 scripts/compare_mt.py