qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5] accel/kvm: Turn DPRINTF macro use into tracepoints


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v5] accel/kvm: Turn DPRINTF macro use into tracepoints
Date: Fri, 1 Dec 2023 11:34:05 +0100
User-agent: Mozilla Thunderbird

Hi Jai,

On 1/12/23 02:36, Jai Arora wrote:
Patch removes DRPINTF macro and adds multiple tracepoints

Typo "DPRINTF".

to capture different kvm events.

We also drop the DPRINTFs that don't add any additional
information than trace_kvm_run_exit already does.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1827

Signed-off-by: Jai Arora <arorajai2798@gmail.com>

Please keep previous tags if the patch is identical:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
---
v5: Adds Reviewed-by tag as requested by Alex Bennee

Added it now, thanks for the feedback. :)

  accel/kvm/kvm-all.c    | 28 ++++++----------------------
  accel/kvm/trace-events |  7 ++++++-
  2 files changed, 12 insertions(+), 23 deletions(-)


diff --git a/accel/kvm/trace-events b/accel/kvm/trace-events
index 399aaeb0ec..f61a21019a 100644
--- a/accel/kvm/trace-events
+++ b/accel/kvm/trace-events
@@ -25,4 +25,9 @@ kvm_dirty_ring_reaper(const char *s) "%s"
  kvm_dirty_ring_reap(uint64_t count, int64_t t) "reaped %"PRIu64" pages (took 
%"PRIi64" us)"
  kvm_dirty_ring_reaper_kick(const char *reason) "%s"
  kvm_dirty_ring_flush(int finished) "%d"
-
+kvm_destroy_vcpu(void) ""
+kvm_failed_get_vcpu_mmap_size(void) ""
+kvm_cpu_exec(void) ""
+kvm_interrupt_exit_request(void) ""
+kvm_io_window_exit(void) ""
+kvm_run_exit_system_event(int cpu_index, uint32_t event_type) "cpu_index %d, 
system_even_type %d"

Nitpicking, the uin32_t type is unsigned, so its format is "%u" ("%d" is
for signed). Also, if the type is uint32_t, the preferred generic format
is PRIu32 (see for example the kvm_dirty_ring_reap trace event earlier).

Regards,

Phil.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]