[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/12] hw/audio/es1370: Clean up comment
From: |
Thomas Huth |
Subject: |
[PULL 12/12] hw/audio/es1370: Clean up comment |
Date: |
Mon, 13 Nov 2023 12:07:40 +0100 |
From: Peter Maydell <peter.maydell@linaro.org>
Replace a sweary comment with one that's a bit more helpful to
future readers of the code.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Volker RĂ¼melin <vr_qemu@t-online.de>
Message-ID: <20231110164318.2197569-1-peter.maydell@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/audio/es1370.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/audio/es1370.c b/hw/audio/es1370.c
index 91c47330ad..fad5541211 100644
--- a/hw/audio/es1370.c
+++ b/hw/audio/es1370.c
@@ -670,8 +670,13 @@ static void es1370_transfer_audio (ES1370State *s, struct
chan *d, int loop_sel,
cnt += (transferred + d->leftover) >> 2;
if (s->sctl & loop_sel) {
- /* Bah, how stupid is that having a 0 represent true value?
- i just spent few hours on this shit */
+ /*
+ * loop_sel tells us which bit in the SCTL register to look at
+ * (either P1_LOOP_SEL, P2_LOOP_SEL or R1_LOOP_SEL). The sense
+ * of these bits is 0 for loop mode (set interrupt and keep recording
+ * when the sample count reaches zero) or 1 for stop mode (set
+ * interrupt and stop recording).
+ */
AUD_log ("es1370: warning", "non looping mode\n");
} else {
d->frame_cnt = size;
--
2.41.0
- [PULL 02/12] s390x/pci: bypass vfio DMA counting when using cdev, (continued)
- [PULL 02/12] s390x/pci: bypass vfio DMA counting when using cdev, Thomas Huth, 2023/11/13
- [PULL 03/12] s390x/pci: only limit DMA aperture if vfio DMA limit reported, Thomas Huth, 2023/11/13
- [PULL 04/12] MAINTAINERS: Add include/hw/input/pl050.h to the PrimeCell/CMSDK section, Thomas Huth, 2023/11/13
- [PULL 05/12] MAINTAINERS: Add hw/input/ads7846.c to the PXA2XX section, Thomas Huth, 2023/11/13
- [PULL 06/12] MAINTAINERS: Add hw/display/sii9022.c to the Versatile Express section, Thomas Huth, 2023/11/13
- [PULL 07/12] MAINTAINERS: Extend the Stellaris section, Thomas Huth, 2023/11/13
- [PULL 08/12] MAINTAINERS: Add a general architecture section for x86, Thomas Huth, 2023/11/13
- [PULL 09/12] tests/vm/netbsd: Use Python v3.11, Thomas Huth, 2023/11/13
- [PULL 11/12] tests/tsan: Rename the file with the entries that should be ignored, Thomas Huth, 2023/11/13
- [PULL 10/12] test-resv-mem: Fix CID 1523911, Thomas Huth, 2023/11/13
- [PULL 12/12] hw/audio/es1370: Clean up comment,
Thomas Huth <=
- Re: [PULL 00/12] Misc patches for 8.2-rc0, Stefan Hajnoczi, 2023/11/13