|
From: | Richard Henderson |
Subject: | Re: [PATCH 2/8] target/sparc: Fix VIS fmul8x16au instruction. |
Date: | Thu, 28 Sep 2023 18:04:52 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 |
On 9/28/23 17:41, Nick Bowler wrote:
On 2023-09-28, Richard Henderson <richard.henderson@linaro.org> wrote:Belated follow-up suggestion: - if ((tmp & 0xff) > 0x7f) { - tmp += 0x100; - } + tmp += 0x80; 7 occurrences throughout vis_helper.c.I agree with making this particular change but I think since it doesn't fix a bug, it should go in a separate patch.
Of course. That's what I meant by followup. r~
[Prev in Thread] | Current Thread | [Next in Thread] |