[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/48] sysemu/hvf: Use vaddr for hvf_arch_[insert|remove]_hw_break
From: |
Richard Henderson |
Subject: |
[PULL 04/48] sysemu/hvf: Use vaddr for hvf_arch_[insert|remove]_hw_breakpoint |
Date: |
Wed, 23 Aug 2023 13:22:42 -0700 |
From: Anton Johansson via <qemu-devel@nongnu.org>
Changes the signature of the target-defined functions for
inserting/removing hvf hw breakpoints. The address and length arguments
are now of vaddr type, which both matches the type used internally in
accel/hvf/hvf-all.c and makes the api target-agnostic.
Signed-off-by: Anton Johansson <anjo@rev.ng>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230807155706.9580-5-anjo@rev.ng>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/sysemu/hvf.h | 6 ++----
target/arm/hvf/hvf.c | 4 ++--
target/i386/hvf/hvf.c | 4 ++--
3 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/include/sysemu/hvf.h b/include/sysemu/hvf.h
index 4cbae87ced..4037cd6a73 100644
--- a/include/sysemu/hvf.h
+++ b/include/sysemu/hvf.h
@@ -51,10 +51,8 @@ int hvf_sw_breakpoints_active(CPUState *cpu);
int hvf_arch_insert_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint *bp);
int hvf_arch_remove_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint *bp);
-int hvf_arch_insert_hw_breakpoint(target_ulong addr, target_ulong len,
- int type);
-int hvf_arch_remove_hw_breakpoint(target_ulong addr, target_ulong len,
- int type);
+int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type);
+int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type);
void hvf_arch_remove_all_hw_breakpoints(void);
/*
diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c
index 8fce64bbf6..486f90be1d 100644
--- a/target/arm/hvf/hvf.c
+++ b/target/arm/hvf/hvf.c
@@ -2063,7 +2063,7 @@ int hvf_arch_remove_sw_breakpoint(CPUState *cpu, struct
hvf_sw_breakpoint *bp)
return 0;
}
-int hvf_arch_insert_hw_breakpoint(target_ulong addr, target_ulong len, int
type)
+int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type)
{
switch (type) {
case GDB_BREAKPOINT_HW:
@@ -2077,7 +2077,7 @@ int hvf_arch_insert_hw_breakpoint(target_ulong addr,
target_ulong len, int type)
}
}
-int hvf_arch_remove_hw_breakpoint(target_ulong addr, target_ulong len, int
type)
+int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type)
{
switch (type) {
case GDB_BREAKPOINT_HW:
diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c
index b9cbcc02a8..cb2cd0b02f 100644
--- a/target/i386/hvf/hvf.c
+++ b/target/i386/hvf/hvf.c
@@ -690,12 +690,12 @@ int hvf_arch_remove_sw_breakpoint(CPUState *cpu, struct
hvf_sw_breakpoint *bp)
return -ENOSYS;
}
-int hvf_arch_insert_hw_breakpoint(target_ulong addr, target_ulong len, int
type)
+int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type)
{
return -ENOSYS;
}
-int hvf_arch_remove_hw_breakpoint(target_ulong addr, target_ulong len, int
type)
+int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type)
{
return -ENOSYS;
}
--
2.34.1
- [PULL 00/48] tcg patch queue, Richard Henderson, 2023/08/23
- [PULL 18/48] target/alpha: Use tcg_gen_movcond_i64 in gen_fold_mzero, Richard Henderson, 2023/08/23
- [PULL 21/48] target/openrisc: Use tcg_gen_negsetcond_*, Richard Henderson, 2023/08/23
- [PULL 11/48] tcg/i386: Drop BYTEH deposits for 64-bit, Richard Henderson, 2023/08/23
- [PULL 10/48] target/m68k: Use tcg_gen_deposit_i32 in gen_partset_reg, Richard Henderson, 2023/08/23
- [PULL 12/48] tcg: Fold deposit with zero to and, Richard Henderson, 2023/08/23
- [PULL 04/48] sysemu/hvf: Use vaddr for hvf_arch_[insert|remove]_hw_breakpoint,
Richard Henderson <=
- [PULL 17/48] tcg: Use tcg_gen_negsetcond_*, Richard Henderson, 2023/08/23
- [PULL 16/48] tcg: Introduce negsetcond opcodes, Richard Henderson, 2023/08/23
- [PULL 08/48] accel/tcg: Widen address arg in tlb_compare_set(), Richard Henderson, 2023/08/23
- [PULL 03/48] sysemu/kvm: Use vaddr for kvm_arch_[insert|remove]_hw_breakpoint, Richard Henderson, 2023/08/23
- [PULL 25/48] tcg/ppc: Implement negsetcond_*, Richard Henderson, 2023/08/23
- [PULL 29/48] tcg/riscv: Implement negsetcond_*, Richard Henderson, 2023/08/23
- [PULL 30/48] tcg/s390x: Implement negsetcond_*, Richard Henderson, 2023/08/23
- [PULL 02/48] accel/hvf: Widen pc/saved_insn for hvf_sw_breakpoint, Richard Henderson, 2023/08/23
- [PULL 05/48] include/exec: Replace target_ulong with abi_ptr in cpu_[st|ld]*(), Richard Henderson, 2023/08/23
- [PULL 34/48] tcg/i386: Merge tcg_out_movcond{32,64}, Richard Henderson, 2023/08/23