Re: [PATCH v6 00/12] Add VIRTIO sound card

[Volker Rümelin]

Hi Manos,

I tested the virtio-sound-pci device. It seems the device works unreliably. Audio playback has a lot of dropouts. I can actually hear my mouse moving around. Audio recording with audacity doesn't work. Either recording stops with an error or the recorded stream is silent.

I'll see if I can change the code so audio playback works reliably. I don't think it makes sense to review the current code as it is. I will of course report any issues I find.

With best regards,
Volker

> This patch series adds an audio device implementing the recent virtio 
> sound spec (1.2) and a corresponding PCI wrapper device.
>
> https://github.com/epilys/qemu-virtio-snd/tree/virtio-snd-v6
>
> Main differences with v5 patch series [^v5]
> <cover.1690626150.git.manos.pitsidianakis@linaro.org>:
>
> - Free any existing PCM stream resources before allocating a new one.
> - Add docs.
>
> [^v5]: 
> https://lore.kernel.org/qemu-devel/cover.1690626150.git.manos.pitsidianakis@linaro.org/
>
> Previously:
>
> [^v4]: 
> https://lore.kernel.org/qemu-devel/cover.1689857559.git.manos.pitsidianakis@linaro.org/
> [^v3]: 
> https://lore.kernel.org/qemu-devel/cover.1689692765.git.manos.pitsidianakis@linaro.org/
>
>
> Emmanouil Pitsidianakis (12):
>   Add virtio-sound device stub
>   Add virtio-sound-pci device
>   virtio-sound: handle control messages and streams
>   virtio-sound: set PCM stream parameters
>   virtio-sound: handle VIRTIO_SND_R_PCM_INFO request
>   virtio-sound: handle VIRTIO_SND_R_PCM_{START,STOP}
>   virtio-sound: handle VIRTIO_SND_PCM_SET_PARAMS
>   virtio-sound: handle VIRTIO_SND_R_PCM_PREPARE
>   virtio-sound: handle VIRTIO_SND_PCM_RELEASE
>   virtio-sound: implement audio output (TX)
>   virtio-sound: implement audio capture (RX)
>   docs/system: add basic virtio-snd documentation
>
>  MAINTAINERS                        |    6 +
>  docs/system/device-emulation.rst   |    1 +
>  docs/system/devices/virtio-snd.rst |   36 +
>  hw/virtio/Kconfig                  |    5 +
>  hw/virtio/meson.build              |    2 +
>  hw/virtio/trace-events             |   20 +
>  hw/virtio/virtio-snd-pci.c         |   91 ++
>  hw/virtio/virtio-snd.c             | 1308 ++++++++++++++++++++++++++++
>  include/hw/pci/pci.h               |    1 +
>  include/hw/virtio/virtio-snd.h     |  158 ++++
>  softmmu/qdev-monitor.c             |    1 +
>  11 files changed, 1629 insertions(+)
>  create mode 100644 docs/system/devices/virtio-snd.rst
>  create mode 100644 hw/virtio/virtio-snd-pci.c
>  create mode 100644 hw/virtio/virtio-snd.c
>  create mode 100644 include/hw/virtio/virtio-snd.h
>
>