Re: [PULL v2 40/44] gdbstub: add test for untimely stop-reply packets

[Richard Henderson]

On 5/18/23 13:04, Taylor Simpson wrote:
> From: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
>
> In the previous commit, we modified gdbstub.c to only send stop-reply
> packets as a response to GDB commands that accept it. Now, let's add a
> test for this intended behavior. Running this test before the fix from
> the previous commit fails as QEMU sends a stop-reply packet
> asynchronously, when GDB was in fact waiting an ACK.
>
> Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> Acked-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> Message-Id: 
> <a30d93b9a8d66e9d9294354cfa2fc3af35f00202.1683214375.git.quic_mathbern@quicinc.com>
> ---
>   tests/guest-debug/run-test.py                    | 16 ++++++++++++----
>   .../tcg/multiarch/system/Makefile.softmmu-target | 16 +++++++++++++++-
>   2 files changed, 27 insertions(+), 5 deletions(-)

This test is failing for me on x86_64 and aarch64 host, aarch64 guest:


qemu-system-aarch64: -gdb unix:path=/tmp/tmptlr0fa8hqemu-gdbstub/gdbstub.socket,server=on: 
info: QEMU waiting for connection on: 
disconnected:unix:/tmp/tmptlr0fa8hqemu-gdbstub/gdbstub.socket,server=on
qemu-system-aarch64: warning: gdbstub: client sent packet while target running

  GREP    file
  untimely-packet.gdb.err
make[1]: *** [/home/rth/qemu/src/tests/tcg/multiarch/system/Makefile.softmmu-target:33: 
run-gdbstub-untimely-packet] Error 1

$ gdb --version
GNU gdb (Debian 13.1-3) 13.1


r~