|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH 3/6] hw/i386/intel_iommu: Fix struct VTDInvDescIEC on big endian hosts |
Date: | Wed, 2 Aug 2023 23:16:25 +0200 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 |
On 2/8/23 15:57, Thomas Huth wrote:
On big endian hosts, we need to reverse the bitfield order in the struct VTDInvDescIEC, just like it is already done for the other bitfields in the various structs of the intel-iommu device. Signed-off-by: Thomas Huth <thuth@redhat.com> --- hw/i386/intel_iommu_internal.h | 9 +++++++++ 1 file changed, 9 insertions(+)
Isn't it a bit hacky? Bitfields can be accessed in a portable way using the deposit/extract API, right?
[Prev in Thread] | Current Thread | [Next in Thread] |