[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 4/8] hw/arm/virt: Check CPU type in machine_run_board_init()
From: |
Gavin Shan |
Subject: |
[PATCH v2 4/8] hw/arm/virt: Check CPU type in machine_run_board_init() |
Date: |
Wed, 26 Jul 2023 10:32:01 +1000 |
Set mc->valid_cpu_{types, models} so that the specified CPU type
can be checked in machine_run_board_init(). We needn't to do the
check by ourselves.
Signed-off-by: Gavin Shan <gshan@redhat.com>
---
hw/arm/virt.c | 39 ++++++++++++++++++++++-----------------
1 file changed, 22 insertions(+), 17 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 7d9dbc2663..debd85614e 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -203,7 +203,7 @@ static const int a15irqmap[] = {
[VIRT_PLATFORM_BUS] = 112, /* ...to 112 + PLATFORM_BUS_NUM_IRQS -1 */
};
-static const char *valid_cpus[] = {
+static const char * const valid_cpu_types[] = {
#ifdef CONFIG_TCG
ARM_CPU_TYPE_NAME("cortex-a7"),
ARM_CPU_TYPE_NAME("cortex-a15"),
@@ -219,19 +219,27 @@ static const char *valid_cpus[] = {
ARM_CPU_TYPE_NAME("cortex-a57"),
ARM_CPU_TYPE_NAME("host"),
ARM_CPU_TYPE_NAME("max"),
+ NULL
};
-static bool cpu_type_valid(const char *cpu)
-{
- int i;
-
- for (i = 0; i < ARRAY_SIZE(valid_cpus); i++) {
- if (strcmp(cpu, valid_cpus[i]) == 0) {
- return true;
- }
- }
- return false;
-}
+static const char * const valid_cpu_models[] = {
+#ifdef CONFIG_TCG
+ "cortex-a7",
+ "cortex-a15",
+ "cortex-a35",
+ "cortex-a55",
+ "cortex-a72",
+ "cortex-a76",
+ "a64fx",
+ "neoverse-n1",
+ "neoverse-v1",
+#endif
+ "cortex-a53",
+ "cortex-a57",
+ "host",
+ "max",
+ NULL
+};
static void create_randomness(MachineState *ms, const char *node)
{
@@ -2030,11 +2038,6 @@ static void machvirt_init(MachineState *machine)
unsigned int smp_cpus = machine->smp.cpus;
unsigned int max_cpus = machine->smp.max_cpus;
- if (!cpu_type_valid(machine->cpu_type)) {
- error_report("mach-virt: CPU type %s not supported",
machine->cpu_type);
- exit(1);
- }
-
possible_cpus = mc->possible_cpu_arch_ids(machine);
/*
@@ -2953,6 +2956,8 @@ static void virt_machine_class_init(ObjectClass *oc, void
*data)
#else
mc->default_cpu_type = ARM_CPU_TYPE_NAME("max");
#endif
+ mc->valid_cpu_types = valid_cpu_types;
+ mc->valid_cpu_models = valid_cpu_models;
mc->get_default_cpu_node_id = virt_get_default_cpu_node_id;
mc->kvm_type = virt_kvm_type;
assert(!mc->get_hotplug_handler);
--
2.41.0
- [PATCH v2 0/8] machine: Unified CPU type check, Gavin Shan, 2023/07/25
- [PATCH v2 1/8] machine: Use error handling when CPU type is checked, Gavin Shan, 2023/07/25
- [PATCH v2 2/8] machine: Introduce helper is_cpu_type_supported(), Gavin Shan, 2023/07/25
- [PATCH v2 3/8] machine: Print supported CPU models instead of typenames, Gavin Shan, 2023/07/25
- [PATCH v2 5/8] hw/arm/virt: Unsupported host CPU model on TCG, Gavin Shan, 2023/07/25
- [PATCH v2 4/8] hw/arm/virt: Check CPU type in machine_run_board_init(),
Gavin Shan <=
- [PATCH v2 6/8] hw/arm/sbsa-ref: Check CPU type in machine_run_board_init(), Gavin Shan, 2023/07/25
- [PATCH v2 7/8] hw/arm: Check CPU type in machine_run_board_init(), Gavin Shan, 2023/07/25
- [PATCH v2 8/8] hw/riscv/shakti_c: Check CPU type in machine_run_board_init(), Gavin Shan, 2023/07/25