[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 7/9] migration: modify migration_channels_and_uri_compatib
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v8 7/9] migration: modify migration_channels_and_uri_compatible() for new QAPI syntax |
Date: |
Wed, 19 Jul 2023 11:12:19 +0100 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Thu, Jul 13, 2023 at 10:57:11AM +0000, Het Gala wrote:
> migration_channels_and_uri_compatible() check for transport mechanism
> suitable for multifd migration gets executed when the caller calls old
> uri syntax. It needs it to be run when using the modern MigrateChannel
> QAPI syntax too.
>
> After URI -> 'MigrateChannel' :
> migration_channels_and_uri_compatible() ->
> migration_channels_and_transport_compatible() passes object as argument
> and check for valid transport mechanism.
>
> Suggested-by: Aravind Retnakaran <aravind.retnakaran@nutanix.com>
> Signed-off-by: Het Gala <het.gala@nutanix.com>
> ---
> migration/migration.c | 25 ++++++++++++++-----------
> 1 file changed, 14 insertions(+), 11 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v8 0/9] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration, Het Gala, 2023/07/13
- [PATCH v8 1/9] migration: New QAPI type 'MigrateAddress', Het Gala, 2023/07/13
- [PATCH v8 5/9] migration: convert exec backend to accept MigrateAddress., Het Gala, 2023/07/13
- [PATCH v8 4/9] migration: convert rdma backend to accept MigrateAddress, Het Gala, 2023/07/13
- [PATCH v8 7/9] migration: modify migration_channels_and_uri_compatible() for new QAPI syntax, Het Gala, 2023/07/13
- Re: [PATCH v8 7/9] migration: modify migration_channels_and_uri_compatible() for new QAPI syntax,
Daniel P . Berrangé <=
- [PATCH v8 6/9] migration: New migrate and migrate-incoming argument 'channels', Het Gala, 2023/07/13
- [PATCH v8 3/9] migration: convert socket backend to accept MigrateAddress, Het Gala, 2023/07/13
- [PATCH v8 2/9] migration: convert migration 'uri' into 'MigrateAddress', Het Gala, 2023/07/13
- [PATCH v8 8/9] migration: Implement MigrateChannelList to migration flow., Het Gala, 2023/07/13
- [PATCH v8 9/9] migration: Add test case for modified QAPI syntax, Het Gala, 2023/07/13