[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 6/6] hw/pci: add comment explaining the reason for checkin
|
From: |
Ani Sinha |
|
Subject: |
Re: [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug |
|
Date: |
Tue, 11 Jul 2023 09:33:46 +0530 |
> On 11-Jul-2023, at 9:21 AM, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> 11.07.2023 06:46, Ani Sinha wrote:
>
>> Sure. Since this is only a comment addition, should I also CC qemu-trivial?
>
> A comment change does not mean the change is trivial. It's a trivial in a
> sense
> the code changes are trivial (actually not-existent), but the meaning of the
> comment
> is not trivial at all. I for one know nothing about this.
This comment was already disucussed in qemu-devel between me, mst and Igor.
Perhaps you missed it.
https://patchwork.kernel.org/project/qemu-devel/patch/20230621024824.3779-1-anisinha@redhat.com/
- [PATCH v8 1/6] tests/acpi: allow changes in DSDT.noacpihp table blob, (continued)
- [PATCH v8 1/6] tests/acpi: allow changes in DSDT.noacpihp table blob, Ani Sinha, 2023/07/05
- [PATCH v8 2/6] tests/acpi/bios-tables-test: use the correct slot on the pcie-root-port, Ani Sinha, 2023/07/05
- [PATCH v8 3/6] tests/acpi/bios-tables-test: update acpi blob q35/DSDT.noacpihp, Ani Sinha, 2023/07/05
- [PATCH v8 5/6] hw/pci: warn when PCIe device is plugged into non-zero slot of downstream port, Ani Sinha, 2023/07/05
- [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug, Ani Sinha, 2023/07/05
- Re: [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug, Ani Sinha, 2023/07/05
- Re: [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug, Michael S. Tsirkin, 2023/07/10
- Re: [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug, Ani Sinha, 2023/07/10
- Re: [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug, Michael Tokarev, 2023/07/10
- Re: [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug,
Ani Sinha <=
- Re: [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug, Michael Tokarev, 2023/07/11
- Re: [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug, Ani Sinha, 2023/07/11
[PATCH v8 6/6] hw/pci: add comment to explain checking for available function 0 in pci hotplug, Ani Sinha, 2023/07/05
[PATCH v8 4/6] tests/qtest/hd-geo-test: fix incorrect pcie-root-port usage and simplify test, Ani Sinha, 2023/07/05