[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/15] hw/net: rtl8139: Remove the logic of padding short frames i
From: |
Jason Wang |
Subject: |
[PULL 07/15] hw/net: rtl8139: Remove the logic of padding short frames in the receive path |
Date: |
Fri, 7 Jul 2023 05:06:20 -0400 |
From: Bin Meng <bmeng@tinylab.org>
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng <bmeng@tinylab.org>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/net/rtl8139.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
index 5f1a4d3..b4df75b 100644
--- a/hw/net/rtl8139.c
+++ b/hw/net/rtl8139.c
@@ -826,7 +826,6 @@ static ssize_t rtl8139_do_receive(NetClientState *nc, const
uint8_t *buf, size_t
uint32_t packet_header = 0;
- uint8_t buf1[MIN_BUF_SIZE + VLAN_HLEN];
static const uint8_t broadcast_macaddr[6] =
{ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
@@ -938,17 +937,6 @@ static ssize_t rtl8139_do_receive(NetClientState *nc,
const uint8_t *buf, size_t
}
}
- /* if too small buffer, then expand it
- * Include some tailroom in case a vlan tag is later removed. */
- if (size < MIN_BUF_SIZE + VLAN_HLEN) {
- memcpy(buf1, buf, size);
- memset(buf1 + size, 0, MIN_BUF_SIZE + VLAN_HLEN - size);
- buf = buf1;
- if (size < MIN_BUF_SIZE) {
- size = MIN_BUF_SIZE;
- }
- }
-
if (rtl8139_cp_receiver_enabled(s))
{
if (!rtl8139_cp_rx_valid(s)) {
--
2.7.4
- [PULL 00/15] Net patches, Jason Wang, 2023/07/07
- [PULL 01/15] virtio-net: correctly report maximum tx_queue_size value, Jason Wang, 2023/07/07
- [PULL 02/15] hw/net: e1000: Remove the logic of padding short frames in the receive path, Jason Wang, 2023/07/07
- [PULL 03/15] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path, Jason Wang, 2023/07/07
- [PULL 04/15] hw/net: i82596: Remove the logic of padding short frames in the receive path, Jason Wang, 2023/07/07
- [PULL 05/15] hw/net: ne2000: Remove the logic of padding short frames in the receive path, Jason Wang, 2023/07/07
- [PULL 06/15] hw/net: pcnet: Remove the logic of padding short frames in the receive path, Jason Wang, 2023/07/07
- [PULL 07/15] hw/net: rtl8139: Remove the logic of padding short frames in the receive path,
Jason Wang <=
- [PULL 08/15] hw/net: sungem: Remove the logic of padding short frames in the receive path, Jason Wang, 2023/07/07
- [PULL 09/15] hw/net: sunhme: Remove the logic of padding short frames in the receive path, Jason Wang, 2023/07/07
- [PULL 11/15] net: socket: prepare to cleanup net_init_socket(), Jason Wang, 2023/07/07
- [PULL 10/15] hw/net: ftgmac100: Drop the small packet check in the receive path, Jason Wang, 2023/07/07
- [PULL 12/15] net: socket: move fd type checking to its own function, Jason Wang, 2023/07/07
- [PULL 13/15] net: socket: remove net_init_socket(), Jason Wang, 2023/07/07
- [PULL 15/15] igb: Remove obsolete workaround for Windows, Jason Wang, 2023/07/07
- [PULL 14/15] e1000e: Add ICR clearing by corresponding IMS bit, Jason Wang, 2023/07/07
- Re: [PULL 00/15] Net patches, Richard Henderson, 2023/07/07