Re: [PATCH v2 2/4] QGA VSS: Replace 'fprintf(stderr' with PRINT_DEBUG

[Philippe Mathieu-Daudé]

On 7/7/23 10:31, Konstantin Kostiuk wrote:
> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> ---
>   qga/vss-win32/install.cpp   | 13 +++++++------
>   qga/vss-win32/requester.cpp |  9 +++++----
>   2 files changed, 12 insertions(+), 10 deletions(-)


> @@ -304,9 +305,9 @@ STDAPI COMRegister(void)
>       }
>       strcpy(tlbPath, dllPath);
>       strcpy(tlbPath+n-3, "tlb");
> -    fprintf(stderr, "Registering " QGA_PROVIDER_NAME ":\n");
> -    fprintf(stderr, "  %s\n", dllPath);
> -    fprintf(stderr, "  %s\n", tlbPath);
> +    qga_debug("Registering " QGA_PROVIDER_NAME ":");
> +    qga_debug("  %s", dllPath);
> +    qga_debug("  %s", tlbPath);

What about:

       qga_debug("Registering " QGA_PROVIDER_NAME ":  %s  %s",
                 dllPath, tlbPath);

>       if (!PathFileExists(tlbPath)) {
>           hr = HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND);
>           errmsg(hr, "Failed to lookup tlb");
> @@ -517,7 +518,7 @@ namespace _com_util
>           }
>   
>           if (mbstowcs(bstr, ascii, len) == (size_t)-1) {
> -            fprintf(stderr, "Failed to convert string '%s' into BSTR", ascii);
> +            qga_debug("Failed to convert string '%s' into BSTR", ascii);
>               bstr[0] = 0;
>           }
>           return bstr;