Re: [PATCH 02/21] q800: add djMEMC memory controller

[Philippe Mathieu-Daudé]

On 2/7/23 17:48, Mark Cave-Ayland wrote:
> The djMEMC controller is used to store information related to the physical 
> memory
> configuration.
>
> Co-developed-by: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>   MAINTAINERS              |   2 +
>   hw/m68k/Kconfig          |   1 +
>   hw/m68k/q800.c           |  10 +++
>   hw/misc/Kconfig          |   3 +
>   hw/misc/djmemc.c         | 135 +++++++++++++++++++++++++++++++++++++++
>   hw/misc/meson.build      |   1 +
>   hw/misc/trace-events     |   4 ++
>   include/hw/m68k/q800.h   |   2 +
>   include/hw/misc/djmemc.h |  30 +++++++++
>   9 files changed, 188 insertions(+)
>   create mode 100644 hw/misc/djmemc.c
>   create mode 100644 include/hw/misc/djmemc.h


> diff --git a/include/hw/misc/djmemc.h b/include/hw/misc/djmemc.h
> new file mode 100644
> index 0000000000..82d4e4a2fe
> --- /dev/null
> +++ b/include/hw/misc/djmemc.h
> @@ -0,0 +1,30 @@
> +/*
> + * djMEMC, macintosh memory and interrupt controller
> + * (Quadra 610/650/800 & Centris 610/650)
> + *
> + * SPDX-License-Identifier: GPL-2.0-or-later
> + */
> +
> +#ifndef HW_MISC_DJMEMC_H
> +#define HW_MISC_DJMEMC_H
> +
> +#include "hw/sysbus.h"
> +
> +#define DJMEMC_SIZE        0x2000
> +#define DJMEMC_NUM_REGS    (0x38 / sizeof(uint32_t))
> +
> +#define DJMEMC_MAXBANKS    10

MAXBANKS doesn't seem used, but not a problem.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>