Re: [PATCH QEMU v7 3/9] qapi/migration: Introduce vcpu-dirty-limit parameters

[Markus Armbruster]

~hyman <hyman@git.sr.ht> writes:

> From: Hyman Huang(黄勇) <yong.huang@smartx.com>
>
> Introduce "vcpu-dirty-limit" migration parameter used
> to limit dirty page rate during live migration.
>
> "vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are
> two dirty-limit-related migration parameters, which can
> be set before and during live migration by qmp
> migrate-set-parameters.
>
> This two parameters are used to help implement the dirty
> page rate limit algo of migration.
>
> Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
> Acked-by: Peter Xu <peterx@redhat.com>
> Reviewed-by: Juan Quintela <quintela@redhat.com>

[...]

> diff --git a/qapi/migration.json b/qapi/migration.json
> index 384b768e03..aa590dbf0e 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -793,6 +793,9 @@
>  #                             live migration. Should be in the range 1 to 
> 1000ms,
>  #                             defaults to 1000ms. (Since 8.1)
>  #
> +# @vcpu-dirty-limit: Dirtyrate limit (MB/s) during live migration.
> +#                    Defaults to 1. (Since 8.1)
> +#

"Dirty rate" with a space, because that's how we spell it elsewhere.

Please format like

   # @vcpu-dirty-limit: Dirty rate limit (MB/s) during live migration.
   #     Defaults to 1. (Since 8.1)
   #

to blend in with recent commit a937b6aa739 (qapi: Reformat doc comments
to conform to current conventions).

>  # Features:
>  #
>  # @unstable: Members @x-checkpoint-delay and @x-vcpu-dirty-limit-period
> @@ -816,7 +819,8 @@
>             'max-cpu-throttle', 'multifd-compression',
>             'multifd-zlib-level', 'multifd-zstd-level',
>             'block-bitmap-mapping',
> -           { 'name': 'x-vcpu-dirty-limit-period', 'features': ['unstable'] } 
> ] }
> +           { 'name': 'x-vcpu-dirty-limit-period', 'features': ['unstable'] },
> +           'vcpu-dirty-limit'] }
>  
>  ##
>  # @MigrateSetParameters:
> @@ -955,6 +959,9 @@
>  #                             live migration. Should be in the range 1 to 
> 1000ms,
>  #                             defaults to 1000ms. (Since 8.1)
>  #
> +# @vcpu-dirty-limit: Dirtyrate limit (MB/s) during live migration.
> +#                    Defaults to 1. (Since 8.1)
> +#

Likewise.

>  # Features:
>  #
>  # @unstable: Members @x-checkpoint-delay and @x-vcpu-dirty-limit-period
> @@ -995,7 +1002,8 @@
>              '*multifd-zstd-level': 'uint8',
>              '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ],
>              '*x-vcpu-dirty-limit-period': { 'type': 'uint64',
> -                                            'features': [ 'unstable' ] } } }
> +                                            'features': [ 'unstable' ] },
> +            '*vcpu-dirty-limit': 'uint64'} }
>  
>  ##
>  # @migrate-set-parameters:
> @@ -1154,6 +1162,9 @@
>  #                             live migration. Should be in the range 1 to 
> 1000ms,
>  #                             defaults to 1000ms. (Since 8.1)
>  #
> +# @vcpu-dirty-limit: Dirtyrate limit (MB/s) during live migration.
> +#                    Defaults to 1. (Since 8.1)
> +#

Likewise.

>  # Features:
>  #
>  # @unstable: Members @x-checkpoint-delay and @x-vcpu-dirty-limit-period
> @@ -1191,7 +1202,8 @@
>              '*multifd-zstd-level': 'uint8',
>              '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ],
>              '*x-vcpu-dirty-limit-period': { 'type': 'uint64',
> -                                            'features': [ 'unstable' ] } } }
> +                                            'features': [ 'unstable' ] },
> +            '*vcpu-dirty-limit': 'uint64'} }
>  
>  ##
>  # @query-migrate-parameters: