[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V3] migration: simplify blockers
From: |
Steven Sistare |
Subject: |
Re: [PATCH V3] migration: simplify blockers |
Date: |
Wed, 5 Jul 2023 17:42:01 -0400 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 |
On 7/5/2023 5:33 PM, Steven Sistare wrote:
> On 6/7/2023 11:58 AM, Peter Xu wrote:
>> On Wed, Jun 07, 2023 at 07:35:32AM -0700, Steve Sistare wrote:
>>> Modify migrate_add_blocker and migrate_del_blocker to take an Error **
>>> reason. This allows migration to own the Error object, so that if
>>> an error occurs, migration code can free the Error and clear the client
>>> handle, simplifying client code.
>>>
>>> This is also a pre-requisite for future patches that will add a mode
>>> argument to migration requests to support live update, and will maintain
>>> a list of blockers for each mode. A blocker may apply to a single mode
>>> or to multiple modes, and passing Error** will allow one Error object to
>>> be registered for multiple modes.
>>>
>>> No functional change.
>>>
>>> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
>>
>> Reviewed-by: Peter Xu <peterx@redhat.com>
>
> Hi Juan,
> This stand-alone patch is ready to be pulled.
Ahh nope, it has been too long and no longer applies cleanly.
I will rebase and repost.
- Steve