Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

[Bernhard Beschow]

Am 3. Juli 2023 07:59:29 UTC schrieb Olaf Hering <olaf@aepfle.de>:
>Sun, 02 Jul 2023 22:18:50 +0000 Bernhard Beschow <shentey@gmail.com>:
>
>> Do you know if that command calls pci_device_reset() (which would eventually 
>> call piix_ide_reset())?
>
>The function is pci_xen_ide_unplug, which calls device_cold_reset.

I think this explains why the BAR isn't reset: Unlike pci_device_reset(), 
device_cold_reset() lacks calling pci_do_device_reset() which would take care 
of the BARs.

Paolo, Peter: Should we switch to pci_device_reset() in pci_xen_ide_unplug()? 
Or is device_cold_reset() supposed to do everything?

Best regards,
Bernhard

>
>
>Olaf