RE: [PATCH v2] Hexagon (target/hexagon) Additional instructions handled by idef-parser

[Taylor Simpson]

> -----Original Message-----
> From: Anton Johansson <anjo@rev.ng>
> Sent: Friday, April 28, 2023 11:25 AM
> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
> Cc: richard.henderson@linaro.org; philmd@linaro.org; ale@rev.ng; Brian Cain
> <bcain@quicinc.com>; Matheus Bernardino (QUIC)
> <quic_mathbern@quicinc.com>
> Subject: Re: [PATCH v2] Hexagon (target/hexagon) Additional instructions
> handled by idef-parser
> 
> On 4/26/23 19:32, Taylor Simpson wrote:
> > **** Changes in v2 ****
> > Fix bug in imm_print identified in clang build
> >
> > Currently, idef-parser skips all floating point instructions.
> > However, there are some floating point instructions that can be handled.
> >
> > The following instructions are now parsed
> >      F2_sfimm_p
> >      F2_sfimm_n
> >      F2_dfimm_p
> >      F2_dfimm_n
> >      F2_dfmpyll
> >      F2_dfmpylh
> >
> > To make these instructions work, we fix some bugs in parser-helpers.c
> >      gen_rvalue_extend
> >      gen_cast_op
> >      imm_print
> >
> > Test cases added to tests/tcg/hexagon/fpstuff.c
> >
> > Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> > ---
> >   target/hexagon/idef-parser/parser-helpers.h |  2 +-
> >   target/hexagon/idef-parser/parser-helpers.c | 37 ++++++++++----
> >   tests/tcg/hexagon/fpstuff.c                 | 54 +++++++++++++++++++++
> >   target/hexagon/gen_idef_parser_funcs.py     | 10 +++-
> >   4 files changed, 91 insertions(+), 12 deletions(-)
> 
> I'm getting a harness failure on
> 
>      v65_Q6_R_mpy_RR_rnd.c
> 
> I'll take a deeper look at this next week.

I'm seeing that failure too.  Thanks for looking into it.

Taylor