[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 09/10] migration: disallow change capabilities in COLO state
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v4 09/10] migration: disallow change capabilities in COLO state |
Date: |
Fri, 28 Apr 2023 22:49:27 +0300 |
COLO is not listed as running state in migrate_is_running(), so, it's
theoretically possible to disable colo capability in COLO state and the
unexpected error in migration_iteration_finish() is reachable.
Let's disallow that in qmp_migrate_set_capabilities. Than the error
becomes absolutely unreachable: we can get into COLO state only with
enabled capability and can't disable it while we are in COLO state. So
substitute the error by simple assertion.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
migration/migration.c | 5 +----
migration/options.c | 2 +-
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 0d912ee0d7..8c5bbf3e94 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2751,10 +2751,7 @@ static void migration_iteration_finish(MigrationState *s)
runstate_set(RUN_STATE_POSTMIGRATE);
break;
case MIGRATION_STATUS_COLO:
- if (!migrate_colo()) {
- error_report("%s: critical error: calling COLO code without "
- "COLO enabled", __func__);
- }
+ assert(migrate_colo());
migrate_start_colo_process(s);
s->vm_was_running = true;
/* Fallthrough */
diff --git a/migration/options.c b/migration/options.c
index 865a0214d8..f461d02eeb 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -598,7 +598,7 @@ void
qmp_migrate_set_capabilities(MigrationCapabilityStatusList *params,
MigrationCapabilityStatusList *cap;
bool new_caps[MIGRATION_CAPABILITY__MAX];
- if (migration_is_running(s->state)) {
+ if (migration_is_running(s->state) || migration_in_colo_state()) {
error_setg(errp, QERR_MIGRATION_ACTIVE);
return;
}
--
2.34.1
- [PATCH v4 00/10] COLO: improve build options, Vladimir Sementsov-Ogievskiy, 2023/04/28
- [PATCH v4 02/10] colo: make colo_checkpoint_notify static and provide simpler API, Vladimir Sementsov-Ogievskiy, 2023/04/28
- [PATCH v4 05/10] migration: drop colo_incoming_thread from MigrationIncomingState, Vladimir Sementsov-Ogievskiy, 2023/04/28
- [PATCH v4 03/10] build: move COLO under CONFIG_REPLICATION, Vladimir Sementsov-Ogievskiy, 2023/04/28
- [PATCH v4 07/10] migration: split migration_incoming_co, Vladimir Sementsov-Ogievskiy, 2023/04/28
- [PATCH v4 04/10] configure: add --disable-colo-proxy option, Vladimir Sementsov-Ogievskiy, 2023/04/28
- [PATCH v4 08/10] migration: process_incoming_migration_co(): move colo part to colo, Vladimir Sementsov-Ogievskiy, 2023/04/28
- [PATCH v4 09/10] migration: disallow change capabilities in COLO state,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v4 10/10] migration: block incoming colo when capability is disabled, Vladimir Sementsov-Ogievskiy, 2023/04/28
- [PATCH v4 06/10] migration: process_incoming_migration_co: simplify code flow around ret, Vladimir Sementsov-Ogievskiy, 2023/04/28
- [PATCH v4 01/10] block/meson.build: prefer positive condition for replication, Vladimir Sementsov-Ogievskiy, 2023/04/28