RE: [PATCH] target/hexagon: fix = vs. == mishap

[Taylor Simpson]

> -----Original Message-----
> From: Taylor Simpson
> Sent: Thursday, April 27, 2023 6:05 PM
> To: Richard Henderson <richard.henderson@linaro.org>; Paolo Bonzini
> <pbonzini@redhat.com>; qemu-devel@nongnu.org
> Subject: RE: [PATCH] target/hexagon: fix = vs. == mishap
> 
> 
> 
> > -----Original Message-----
> > From: Richard Henderson <richard.henderson@linaro.org>
> > Sent: Thursday, April 27, 2023 8:33 AM
> > To: Paolo Bonzini <pbonzini@redhat.com>; qemu-devel@nongnu.org
> > Cc: Taylor Simpson <tsimpson@quicinc.com>
> > Subject: Re: [PATCH] target/hexagon: fix = vs. == mishap
> >
> > WARNING: This email originated from outside of Qualcomm. Please be
> wary
> > of any links or attachments, and do not enable macros.
> >
> > On 4/27/23 13:56, Paolo Bonzini wrote:
> > > Coverity reports a parameter that is "set but never used".  This is
> > > caused by an assignment operator being used instead of equality.
> > >
> > > Cc: Taylor Simpson<tsimpson@quicinc.com>
> > > Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> > > ---
> > >   target/hexagon/idef-parser/parser-helpers.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> 
> Queued with next Hexagon update

This patch is causing some yyassert's when idef-parser runs.  They are coming 
from sign and zero extends.
WARNING (A2_vavgw): 'Extending to a size smaller than the current size makes no 
sense'

I will investigate.

Taylor