[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] async: Suppress GCC13 false positive in aio_bh_poll()
From: |
Juan Quintela |
Subject: |
Re: [PATCH] async: Suppress GCC13 false positive in aio_bh_poll() |
Date: |
Fri, 28 Apr 2023 18:24:17 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il mar 25 apr 2023, 15:31 Daniel P. Berrangé <berrange@redhat.com> ha
> scritto:
>
>> > > - BHListSlice slice;
>> > > + /*
>> > > + * gcc13 complains about putting a local variable
>> > > + * in a global list, so put it on the heap.
>> > > + */
>> > > + g_autofree BHListSlice *slice = g_new(BHListSlice, 1);
>> > > BHListSlice *s;
>> > > int ret = 0;
>> > >
>> >
>> > This must be a memory leak since you're adding a g_new but not
>> > adding any g_free
>>
>> Sorry, I'm failing to read properly today. It uses g_autofree
>> so there is no leak.
>>
>
> On the other hand, if the pointer to the heap-allocated BHListSlice
> escaped, this would be a dangling pointer as well—just not the kind that
> the new GCC warning can report.
I don't agree here.
If with my patch it becomes a dangling pointer because we free it.
With Cedric patch it is a local variable that gets exited out of the
function that created it.
Choose your poison. One thing is bad and the other is worse.
> So this patch is also doing nothing but shut up the compiler; but it's
> doing so in an underhanded manner and with a runtime cost, and as such it's
> worse than Cedric's patch.
Ok. I don't care (enogouh) about this to continue a discussion.. Can we
get Cedric patch upstream?
Thanks, Juan.
- Re: [PATCH] async: Suppress GCC13 false positive in aio_bh_poll(), (continued)
- Re: [PATCH] async: Suppress GCC13 false positive in aio_bh_poll(), Daniel Henrique Barboza, 2023/04/20
- Re: [PATCH] async: Suppress GCC13 false positive in aio_bh_poll(), Philippe Mathieu-Daudé, 2023/04/21
- Re: [PATCH] async: Suppress GCC13 false positive in aio_bh_poll(), Stefan Hajnoczi, 2023/04/22
- Re: [PATCH] async: Suppress GCC13 false positive in aio_bh_poll(), Thomas Huth, 2023/04/24
- Re: [PATCH] async: Suppress GCC13 false positive in aio_bh_poll(), Juan Quintela, 2023/04/25
Re: [PATCH] async: Suppress GCC13 false positive in aio_bh_poll(), Paolo Bonzini, 2023/04/28