[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/17] qapi: Fix up references to long gone error classes
From: |
Markus Armbruster |
Subject: |
[PULL 04/17] qapi: Fix up references to long gone error classes |
Date: |
Fri, 28 Apr 2023 12:28:48 +0200 |
Commit de253f14912e88f4 (qmp: switch to the new error format on the
wire) removed most error classes. Several later commits mistakenly
mentioned them in documentation. Replace them by the actual error
class there.
Fixes: 44e3e053af56 (qmp: add interface blockdev-snapshot-delete-internal-sync)
Fixes: f323bc9e8b3b (qmp: add interface blockdev-snapshot-internal-sync)
Fixes: ba1c048a8f9c (qapi: Introduce add-fd, remove-fd, query-fdsets)
Fixes: ed61fc10e8c8 (QAPI: add command for live block commit, 'block-commit')
Fixes: e4c8f004c55d (qapi: convert sendkey)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230425064223.820979-5-armbru@redhat.com>
---
qapi/block-core.json | 4 ++--
qapi/misc.json | 6 +++---
qapi/ui.json | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index c05ad0c07e..75f7c62405 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -5784,7 +5784,7 @@
# - If any snapshot matching @name exists, or @name is empty,
# GenericError
# - If the format of the image used does not support it,
-# BlockFormatFeatureNotSupported
+# GenericError
#
# Since: 1.7
#
@@ -5820,7 +5820,7 @@
# - If @device is not a valid block device, GenericError
# - If snapshot not found, GenericError
# - If the format of the image used does not support it,
-# BlockFormatFeatureNotSupported
+# GenericError
# - If @id and @name are both not specified, GenericError
#
# Since: 1.7
diff --git a/qapi/misc.json b/qapi/misc.json
index 6ddd16ea28..7e278ca1eb 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -349,8 +349,8 @@
# @opaque: A free-form string that can be used to describe the fd.
#
# Returns: - @AddfdInfo on success
-# - If file descriptor was not received, FdNotSupplied
-# - If @fdset-id is a negative value, InvalidParameterValue
+# - If file descriptor was not received, GenericError
+# - If @fdset-id is a negative value, GenericError
#
# Notes: The list of fd sets is shared by all monitor connections.
#
@@ -379,7 +379,7 @@
# @fd: The file descriptor that is to be removed.
#
# Returns: - Nothing on success
-# - If @fdset-id or @fd is not found, FdNotFound
+# - If @fdset-id or @fd is not found, GenericError
#
# Since: 1.2
#
diff --git a/qapi/ui.json b/qapi/ui.json
index 7ddd27a932..2d9b34b105 100644
--- a/qapi/ui.json
+++ b/qapi/ui.json
@@ -985,7 +985,7 @@
# to 100
#
# Returns: - Nothing on success
-# - If key is unknown or redundant, InvalidParameter
+# - If key is unknown or redundant, GenericError
#
# Since: 1.3
#
--
2.39.2
- [PULL 00/17] QAPI patches patches for 2023-04-28, Markus Armbruster, 2023/04/28
- [PULL 04/17] qapi: Fix up references to long gone error classes,
Markus Armbruster <=
- [PULL 12/17] qapi: Fix argument documentation markup, Markus Armbruster, 2023/04/28
- [PULL 06/17] qapi: @foo should be used to reference, not ``foo``, Markus Armbruster, 2023/04/28
- [PULL 09/17] qapi: Fix bullet list markup in documentation, Markus Armbruster, 2023/04/28
- [PULL 03/17] qapi: Fix misspelled references, Markus Armbruster, 2023/04/28
- [PULL 01/17] qga/qapi-schema: Tidy up documentation of guest-fsfreeze-status, Markus Armbruster, 2023/04/28
- [PULL 15/17] qapi: Format since information the conventional way: (since X.Y), Markus Armbruster, 2023/04/28
- [PULL 05/17] qapi/block-core: Clean up after removal of dirty bitmap @status, Markus Armbruster, 2023/04/28
- [PULL 13/17] qapi: Replace ad hoc "since" documentation by member documentation, Markus Armbruster, 2023/04/28
- [PULL 16/17] qapi storage-daemon/qapi: Fix documentation section structure, Markus Armbruster, 2023/04/28
- [PULL 08/17] qapi: Delete largely misleading "Stability Considerations", Markus Armbruster, 2023/04/28