[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/16] qapi qga/qapi-schema: Doc fixes
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 00/16] qapi qga/qapi-schema: Doc fixes |
Date: |
Fri, 28 Apr 2023 11:41:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:
> On 04.04.23 14:58, Markus Armbruster wrote:
>> It's always nice to get doc fixes into the release, but if it's too
>> late, it's too late.
>> Generated code does not change, except for the last patch, which moves
>> a bit of code without changing it.
>
>
> I didn't deeply check the details, but looked through and nothing seems wrong
> to me. Good cleanup!
>
> all patches:
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Thanks! (Belatedly)
> PS: do you plan some automatic checks in build process to avoid similar
> style/naming problems in future?
I'm about to post patches that make it somewhat harder to screw up
indentation (PATCH 10 fixes such screwups). Harder, not impossible,
because indentation is meaningful in rST.
I believe the best way to catch argument description screwups is making
argument descriptions mandatory. I hope to find time for that.
Other than that, no promising ideas, I'm afraid.
- [PATCH 16/16] qapi storage-daemon/qapi: Fix documentation section structure, (continued)
- [PATCH 16/16] qapi storage-daemon/qapi: Fix documentation section structure, Markus Armbruster, 2023/04/04
- [PATCH 11/16] qga/qapi-schema: Fix member documentation markup, Markus Armbruster, 2023/04/04
- [PATCH 14/16] qapi: Fix misspelled section tags in doc comments, Markus Armbruster, 2023/04/04
- [PATCH 15/16] qapi: Format since information the conventional way: (since X.Y), Markus Armbruster, 2023/04/04
- Re: [PATCH 00/16] qapi qga/qapi-schema: Doc fixes, Vladimir Sementsov-Ogievskiy, 2023/04/04
- Re: [PATCH 00/16] qapi qga/qapi-schema: Doc fixes,
Markus Armbruster <=
- Re: [PATCH 00/16] qapi qga/qapi-schema: Doc fixes, Marc-André Lureau, 2023/04/04