[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 17/21] Hexagon (target/hexagon) Move new_value to DisasContex
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 17/21] Hexagon (target/hexagon) Move new_value to DisasContext |
|
Date: |
Thu, 27 Apr 2023 12:01:22 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 |
On 4/26/23 01:42, Taylor Simpson wrote:
+ for (i = 0; i < TOTAL_PER_THREAD_REGS; i++) {
+ ctx->new_value[i] = NULL;
+ }
Perhaps
memset(ctx->new_value, 0, sizeof(ctx->new_value));
Though probably the compiler would make that transformation.
Or perhaps
- DisasContext ctx;
+ DisasContext ctx = { 0 };
in gen_intermediate_code, and eliminate other 0 init in gen_start_packet?
But it's not wrong as-is, so,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH 10/21] Hexagon (target/hexagon) Mark registers as read during packet analysis, Taylor Simpson, 2023/04/25
- [PATCH 11/21] Hexagon (target/hexagon) Short-circuit packet register writes, Taylor Simpson, 2023/04/25
- [PATCH 17/21] Hexagon (target/hexagon) Move new_value to DisasContext, Taylor Simpson, 2023/04/25
- Re: [PATCH 17/21] Hexagon (target/hexagon) Move new_value to DisasContext,
Richard Henderson <=
- [PATCH 13/21] Hexagon (target/hexagon) Short-circuit packet HVX writes, Taylor Simpson, 2023/04/25
- [PATCH 19/21] Hexagon (target/hexagon) Move pred_written to DisasContext, Taylor Simpson, 2023/04/25
- [PATCH 16/21] Hexagon (target/hexagon) Make special new_value for USR, Taylor Simpson, 2023/04/25
- [PATCH 15/21] Hexagon (target/hexagon) Add overrides for disabled idef-parser insns, Taylor Simpson, 2023/04/25
- [PATCH 14/21] Hexagon (target/hexagon) Short-circuit more HVX single instruction packets, Taylor Simpson, 2023/04/25