Re: [PATCH v5 0/2] Migration: Make more ram_counters atomic

[Juan Quintela]

Juan Quintela <quintela@redhat.com> wrote:

self-NACK

Working on top of paolo stat64_set() function.



> Hi
>
> In this v5:
>
> Not only change the type of the counters, also use the __nocheck()
> variants of the functions.
>
> Please, review.
>
> [v4]
> - Change aligned_uint64_t to size_t to make (some) 32bit hosts happy.
>
> Please review.
>
> [v3]
> - Addressed reviews
> - All counters are now atomic, either Stat64 or atomic.
> - Rename duplicated to zero_pages
> - Rename normal to zero_pages.
>
> Please review.
>
> [v2]
> - fix typos found by David Edmondson
> - Add review-by tags.
>
> Please review.
>
> [v1]
> On previous series we cerate ram_atomic_counters.  But we basically
> need that all counters are atomic.  So move back to only have
> ram_counters, just with a new type that allows the atomic counters.
>
> Once there, move update of stats out of RAM mutex.
> And make multifd_bytes atomic.
>
> Later, Juan.
>
> Juan Quintela (2):
>   migration: Make dirty_pages_rate atomic
>   migration: Make dirty_bytes_last_sync atomic
>
>  migration/migration.c | 9 ++++++---
>  migration/ram.c       | 7 ++++---
>  migration/ram.h       | 4 ++--
>  3 files changed, 12 insertions(+), 8 deletions(-)