Re: [PATCH 08/21] Hexagon (target/hexagon) Clean up pred_written usage

[Richard Henderson]

On 4/26/23 22:27, Taylor Simpson wrote:
> > > We remove the last use of check_for_attrib.  However, new uses will be
> > > introduced later in this series, so we change it to "static inline".
> >
> > This is insufficient -- clang will warn about unused inline functions within the
> > main C file (as opposed to #included).
> >
> > Use __attribute__((unused)) instead, and remove it when it gains new
> > unconditional uses.
>
> Is it OK to use the attribute itself or is G_GNUC_UNUSED preferred?

I've been using the attribute itself in my patches, e.g.

20230424054105.1579315-1-richard.henderson@linaro.org/T/#mb07f0d1393f7f0a252f459dca6a91a2162581281">https://lore.kernel.org/qemu-devel/20230424054105.1579315-1-richard.henderson@linaro.org/T/#mb07f0d1393f7f0a252f459dca6a91a2162581281

But either is fine with me.


r~