Re: [PATCH 05/21] Hexagon (target/hexagon) Add overrides for clr[tf]new

[Richard Henderson]

On 4/26/23 01:41, Taylor Simpson wrote:
> These instructions have implicit reads from p0, so we don't want
> them in helpers when idef-parser is off.
>
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
>   target/hexagon/gen_tcg.h | 18 ++++++++++++++++++
>   target/hexagon/macros.h  |  4 ----
>   2 files changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/target/hexagon/gen_tcg.h b/target/hexagon/gen_tcg.h
> index 7c5cb93297..5e87d1d861 100644
> --- a/target/hexagon/gen_tcg.h
> +++ b/target/hexagon/gen_tcg.h
> @@ -1097,6 +1097,24 @@
>           gen_jump(ctx, riV); \
>       } while (0)
>   
> +/* if (p0.new) r0 = #0 */
> +#define fGEN_TCG_SA1_clrtnew(SHORTCODE) \
> +    do { \
> +        TCGLabel *skip = gen_new_label(); \
> +        tcg_gen_brcondi_tl(TCG_COND_EQ, hex_new_pred_value[0], 0, skip); \
> +        tcg_gen_movi_tl(RdV, 0); \
> +        gen_set_label(skip); \
> +    } while (0)

This ought to be a movcond.

> +
> +/* if (!p0.new) r0 = #0 */
> +#define fGEN_TCG_SA1_clrfnew(SHORTCODE) \
> +    do { \
> +        TCGLabel *skip = gen_new_label(); \
> +        tcg_gen_brcondi_tl(TCG_COND_NE, hex_new_pred_value[0], 0, skip); \
> +        tcg_gen_movi_tl(RdV, 0); \
> +        gen_set_label(skip); \
> +    } while (0)

Likewise.


r~