[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 09/13] migration: Create migrate_tls_creds() function
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH v3 09/13] migration: Create migrate_tls_creds() function |
|
Date: |
Wed, 26 Apr 2023 21:40:54 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:
> On 24.04.23 21:32, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> could be stricter "const char *"
I change changed the patch just to reflect this.
>
>> @@ -34,20 +34,19 @@ migration_tls_get_creds(MigrationState *s,
>> Error **errp)
>
> "s" argument becomes unused, may be dropped.
Good catch!
I created the patches for this, will send after I send the PULL request.
Thanks, Juan.
- [PATCH v3 04/13] migration: Make all functions check have the same format, (continued)
- [PATCH v3 04/13] migration: Make all functions check have the same format, Juan Quintela, 2023/04/24
- [PATCH v3 06/13] migration: Move migrate_set_block_incremental() to options.c, Juan Quintela, 2023/04/24
- [PATCH v3 11/13] migration: Create migrate_tls_hostname() function, Juan Quintela, 2023/04/24
- [PATCH v3 09/13] migration: Create migrate_tls_creds() function, Juan Quintela, 2023/04/24
- [PATCH v3 12/13] migration: Create migrate_block_bitmap_mapping() function, Juan Quintela, 2023/04/24
- [PATCH v3 08/13] migration: Remove MigrationState from block_cleanup_parameters(), Juan Quintela, 2023/04/24
- [PATCH v3 10/13] migration: Create migrate_tls_authz() function, Juan Quintela, 2023/04/24
- [PATCH v3 13/13] migration: Move migration_properties to options.c, Juan Quintela, 2023/04/24