[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] acpi: pcihp: allow repeating hot-unplug requests
From: |
Kashyap Chamarthy |
Subject: |
Re: [PATCH v4] acpi: pcihp: allow repeating hot-unplug requests |
Date: |
Wed, 26 Apr 2023 19:20:08 +0200 |
On Wed, Apr 26, 2023 at 07:40:02PM +0300, Michael Tokarev wrote:
> 18.04.2023 12:04, Igor Mammedov wrote:
> > with Q35 using ACPI PCI hotplug by default, user's request to unplug
> > device is ignored when it's issued before guest OS has been booted.
> > And any additional attempt to request device hot-unplug afterwards
> > results in following error:
> >
> > "Device XYZ is already in the process of unplug"
> >
> > arguably it can be considered as a regression introduced by [2],
> > before which it was possible to issue unplug request multiple
> > times.
>
> Stable-8.0 material?
FWIW, I'd say, yes. This fix is useful for stable releases. As this
solves a real problem for upper-management tools.
I have tested this fix; and it works. I'll post my testing notes /
reproducer in a follow-up email. In short, I followed the
reproducer steps from here[1].
[1] https://gitlab.com/libvirt/libvirt/-/issues/309
--
/kashyap