Re: [PATCH] linux-user: report ENOTTY for unknown ioctls

[Philippe Mathieu-Daudé]

On 26/4/23 09:06, Thomas Weißschuh wrote:
> The correct error number for unknown ioctls is ENOTTY.
>
> ENOSYS would mean that the ioctl() syscall itself is not implemented,
> which is very improbable and unexpected for userspace.
>
> ENOTTY means "Inappropriate ioctl for device". This is what the kernel
> returns on unknown ioctls, what qemu is trying to express and what
> userspace is prepared to handle.
>
> Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
> ---
>   linux-user/syscall.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>