[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 45/48] igb: Clear-on-read ICR when ICR.INTA is set
From: |
Akihiko Odaki |
Subject: |
[PATCH v4 45/48] igb: Clear-on-read ICR when ICR.INTA is set |
Date: |
Wed, 26 Apr 2023 19:37:13 +0900 |
For GPIE.NSICR, Section 7.3.2.1.2 says:
> ICR bits are cleared on register read. If GPIE.NSICR = 0b, then the
> clear on read occurs only if no bit is set in the IMS or at least one
> bit is set in the IMS and there is a true interrupt as reflected in
> ICR.INTA.
e1000e does similar though it checks for CTRL_EXT.IAME, which does not
exist on igb.
Suggested-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
hw/net/igb_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index b68e24c9ee..29190054c6 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -2598,6 +2598,8 @@ igb_mac_icr_read(IGBCore *core, int index)
} else if (core->mac[IMS] == 0) {
trace_e1000e_irq_icr_clear_zero_ims();
igb_lower_interrupts(core, ICR, 0xffffffff);
+ } else if (core->mac[ICR] & E1000_ICR_INT_ASSERTED) {
+ igb_lower_interrupts(core, ICR, 0xffffffff);
} else if (!msix_enabled(core->owner)) {
trace_e1000e_irq_icr_clear_nonmsix_icr_read();
igb_lower_interrupts(core, ICR, 0xffffffff);
--
2.40.0
- [PATCH v4 36/48] igb: Implement Rx SCTP CSO, (continued)
- [PATCH v4 36/48] igb: Implement Rx SCTP CSO, Akihiko Odaki, 2023/04/26
- [PATCH v4 37/48] igb: Implement Tx SCTP CSO, Akihiko Odaki, 2023/04/26
- [PATCH v4 38/48] igb: Strip the second VLAN tag for extended VLAN, Akihiko Odaki, 2023/04/26
- [PATCH v4 39/48] igb: Filter with the second VLAN tag for extended VLAN, Akihiko Odaki, 2023/04/26
- [PATCH v4 40/48] igb: Implement igb-specific oversize check, Akihiko Odaki, 2023/04/26
- [PATCH v4 41/48] igb: Implement Rx PTP2 timestamp, Akihiko Odaki, 2023/04/26
- [PATCH v4 42/48] igb: Implement Tx timestamp, Akihiko Odaki, 2023/04/26
- [PATCH v4 43/48] e1000e: Notify only new interrupts, Akihiko Odaki, 2023/04/26
- [PATCH v4 44/48] igb: Notify only new interrupts, Akihiko Odaki, 2023/04/26
- [PATCH v4 45/48] igb: Clear-on-read ICR when ICR.INTA is set,
Akihiko Odaki <=
- [PATCH v4 46/48] vmxnet3: Do not depend on PC, Akihiko Odaki, 2023/04/26
- [PATCH v4 47/48] MAINTAINERS: Add a reviewer for network packet abstractions, Akihiko Odaki, 2023/04/26
- [PATCH v4 48/48] docs/system/devices/igb: Note igb is tested for DPDK, Akihiko Odaki, 2023/04/26