[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] multifd: Avoid busy-wait in multifd_send_pages()
From: |
manish.mishra |
Subject: |
[PATCH] multifd: Avoid busy-wait in multifd_send_pages() |
Date: |
Tue, 25 Apr 2023 16:05:55 +0000 |
multifd_send_sync_main() posts request on the multifd channel
but does not call sem_wait() on channels_ready semaphore, making
the channels_ready semaphore count keep increasing.
As a result, sem_wait() on channels_ready in multifd_send_pages()
is always non-blocking hence multifd_send_pages() keeps searching
for a free channel in a busy loop until a channel is freed.
Signed-off-by: manish.mishra <manish.mishra@nutanix.com>
---
migration/multifd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index cce3ad6988..43d26e7012 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -615,6 +615,7 @@ int multifd_send_sync_main(QEMUFile *f)
trace_multifd_send_sync_main_signal(p->id);
+ qemu_sem_wait(&multifd_send_state->channels_ready);
qemu_mutex_lock(&p->mutex);
if (p->quit) {
@@ -919,7 +920,7 @@ int multifd_save_setup(Error **errp)
multifd_send_state = g_malloc0(sizeof(*multifd_send_state));
multifd_send_state->params = g_new0(MultiFDSendParams, thread_count);
multifd_send_state->pages = multifd_pages_init(page_count);
- qemu_sem_init(&multifd_send_state->channels_ready, 0);
+ qemu_sem_init(&multifd_send_state->channels_ready, thread_count);
qatomic_set(&multifd_send_state->exiting, 0);
multifd_send_state->ops = multifd_ops[migrate_multifd_compression()];
--
2.22.3
- [PATCH] multifd: Avoid busy-wait in multifd_send_pages(),
manish.mishra <=