qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pci: make ROM memory resizable


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH] pci: make ROM memory resizable
Date: Tue, 25 Apr 2023 13:55:55 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0

On 24.04.23 23:36, Vladimir Sementsov-Ogievskiy wrote:
On migration, on target we load local ROM file. But actual ROM content
migrates through migration channel. Original ROM content from local
file doesn't matter. But when size mismatch - we have an error like

  Size mismatch: 0000:00:03.0/virtio-net-pci.rom: 0x40000 != 0x80000: Invalid 
argument

Let's just allow resizing of ROM memory. This way migration is not
relate on local ROM file on target node which is loaded by default but
is not actually needed.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

Seems, automatically reconfigure the memory on incoming migration is not so 
easy.. ROM size really influence config of the device, and after some digging 
in the code I still cannot say where it happens.

So, I'm going to suggest another way, new series "[PATCH 0/3] ROM migration" 
will substitute this patch.

--
Best regards,
Vladimir




reply via email to

[Prev in Thread] Current Thread [Next in Thread]