[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v3 13/20] configure: create a python venv unconditionally
From: |
John Snow |
Subject: |
[RFC PATCH v3 13/20] configure: create a python venv unconditionally |
Date: |
Mon, 24 Apr 2023 16:02:41 -0400 |
This patch changes the configure script so that it always creates and
uses a python virtual environment unconditionally.
Meson bootstrapping is temporarily altered to force the use of meson
from git or vendored source. The next commit restores the use of
distribution-vendored Meson.
Signed-off-by: John Snow <jsnow@redhat.com>
---
configure | 36 +++++++++++++++++++++++++++++++-----
1 file changed, 31 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 77c03315f8..462fe604d6 100755
--- a/configure
+++ b/configure
@@ -625,7 +625,6 @@ check_py_version() {
python=
first_python=
if test -z "${PYTHON}"; then
- explicit_python=no
# A bare 'python' is traditionally python 2.x, but some distros
# have it as python 3.x, so check in both places.
for binary in python3 python python3.11 python3.10 python3.9 python3.8
python3.7 python3.6; do
@@ -644,7 +643,6 @@ else
# Same as above, but only check the environment variable.
has "${PYTHON}" || error_exit "The PYTHON environment variable does not
point to an executable"
python=$(command -v "$PYTHON")
- explicit_python=yes
if check_py_version "$python"; then
# This one is good.
first_python=
@@ -729,7 +727,7 @@ for opt do
;;
--install=*)
;;
- --python=*) python="$optarg" ; explicit_python=yes
+ --python=*) python="$optarg"
;;
--skip-meson) skip_meson=yes
;;
@@ -1089,8 +1087,34 @@ if ! check_py_version "$python"; then
"Use --python=/path/to/python to specify a supported Python."
fi
-# Resolve PATH + suppress writing compiled files
-python="$(command -v "$python") -B"
+# Resolve PATH
+python="$(command -v "$python")"
+explicit_python=yes
+
+# Create a Python virtual environment using our configured python.
+# The stdout of this script will be the location of a symlink that
+# points to the configured Python.
+# Entry point scripts for pip, meson, and sphinx are generated if those
+# packages are present.
+
+# Defaults assumed for now:
+# - venv is cleared if it exists already;
+# - venv is allowed to use system packages;
+# - all setup is performed **offline**;
+# - No packages are installed by default;
+# - pip is not installed into the venv when possible,
+# but ensurepip is called as a fallback when necessary.
+
+echo "python determined to be '$python'"
+echo "python version: $($python --version)"
+
+python="$($python -B "${source_path}/python/scripts/mkvenv.py" create --gen
pip,meson,sphinx pyvenv)"
+if test "$?" -ne 0 ; then
+ error_exit "python venv creation failed"
+fi
+
+# Suppress writing compiled files
+python="$python -B"
has_meson() {
local python_dir=$(dirname "$python")
@@ -1145,6 +1169,8 @@ case "$meson" in
*) meson=$(command -v "$meson") ;;
esac
+echo "MKVENV ok!"
+
# Probe for ninja
if test -z "$ninja"; then
--
2.39.2
- [RFC PATCH v3 02/20] python: add mkvenv.py, (continued)
- [RFC PATCH v3 02/20] python: add mkvenv.py, John Snow, 2023/04/24
- [RFC PATCH v3 08/20] mkvenv: add ensure subcommand, John Snow, 2023/04/24
- [RFC PATCH v3 07/20] mkvenv: add nested venv workaround, John Snow, 2023/04/24
- [RFC PATCH v3 10/20] tests/vm: Configure netbsd to use Python 3.10, John Snow, 2023/04/24
- [RFC PATCH v3 09/20] tests/docker: add python3-venv dependency, John Snow, 2023/04/24
- [RFC PATCH v3 11/20] tests/vm: add py310-expat to NetBSD, John Snow, 2023/04/24
- [RFC PATCH v3 13/20] configure: create a python venv unconditionally,
John Snow <=
- [RFC PATCH v3 15/20] configure: add --enable-pypi and --disable-pypi, John Snow, 2023/04/24
- [RFC PATCH v3 12/20] scripts/make-release: download meson==0.61.5 .whl, John Snow, 2023/04/24
- [RFC PATCH v3 14/20] configure: use 'mkvenv ensure meson' to bootstrap meson, John Snow, 2023/04/24
- [RFC PATCH v3 01/20] python: update pylint configuration, John Snow, 2023/04/24
- [RFC PATCH v3 16/20] tests: Use configure-provided pyvenv for tests, John Snow, 2023/04/24
- [RFC PATCH v3 17/20] configure: move --enable-docs and --disable-docs back to configure, John Snow, 2023/04/24