[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v3 04/20] mkvenv: Add better error message for missing pyexpa
From: |
John Snow |
Subject: |
[RFC PATCH v3 04/20] mkvenv: Add better error message for missing pyexpat module |
Date: |
Mon, 24 Apr 2023 16:02:32 -0400 |
NetBSD debundles pyexpat from python, but ensurepip needs pyexpat. Try
our best to offer a helpful error message instead of just failing
catastrophically.
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/scripts/mkvenv.py | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/python/scripts/mkvenv.py b/python/scripts/mkvenv.py
index f355cb54fb..2172774403 100644
--- a/python/scripts/mkvenv.py
+++ b/python/scripts/mkvenv.py
@@ -126,7 +126,10 @@ def check_ensurepip(with_pip: bool) -> None:
Raise a fatal exception with a helpful hint if it isn't available.
"""
- if with_pip and not find_spec("ensurepip"):
+ if not with_pip:
+ return
+
+ if not find_spec("ensurepip"):
msg = (
"Python's ensurepip module is not found.\n"
"It's normally part of the Python standard library, "
@@ -138,6 +141,19 @@ def check_ensurepip(with_pip: bool) -> None:
)
raise Ouch(msg)
+ # ensurepip uses pyexpat, which can also go missing on us:
+ if not find_spec("pyexpat"):
+ msg = (
+ "Python's pyexpat module is not found.\n"
+ "It's normally part of the Python standard library, "
+ "maybe your distribution packages it separately?\n"
+ "Either install pyexpat, or alleviate the need for it in the "
+ "first place by installing pip and setuptools for "
+ f"'{sys.executable}'.\n\n"
+ "(Hint: NetBSD's pkgsrc debundles this to e.g. 'py310-expat'.)"
+ )
+ raise Ouch(msg)
+
def make_venv( # pylint: disable=too-many-arguments
env_dir: Union[str, Path],
--
2.39.2
- [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx, John Snow, 2023/04/24
- [RFC PATCH v3 05/20] mkvenv: generate console entry shims from inside the venv, John Snow, 2023/04/24
- [RFC PATCH v3 03/20] mkvenv: add console script entry point generation, John Snow, 2023/04/24
- [RFC PATCH v3 06/20] mkvenv: work around broken pip installations on Debian 10, John Snow, 2023/04/24
- [RFC PATCH v3 04/20] mkvenv: Add better error message for missing pyexpat module,
John Snow <=
- [RFC PATCH v3 02/20] python: add mkvenv.py, John Snow, 2023/04/24
- [RFC PATCH v3 08/20] mkvenv: add ensure subcommand, John Snow, 2023/04/24
- [RFC PATCH v3 07/20] mkvenv: add nested venv workaround, John Snow, 2023/04/24
- [RFC PATCH v3 10/20] tests/vm: Configure netbsd to use Python 3.10, John Snow, 2023/04/24
- [RFC PATCH v3 09/20] tests/docker: add python3-venv dependency, John Snow, 2023/04/24
- [RFC PATCH v3 11/20] tests/vm: add py310-expat to NetBSD, John Snow, 2023/04/24