|
From: | Alex Bennée |
Subject: | Re: [PATCH 1/2] hw/sd/allwinner-sdhost: Correctly byteswap descriptor fields |
Date: | Mon, 24 Apr 2023 18:42:27 +0100 |
User-agent: | mu4e 1.11.3; emacs 29.0.90 |
Peter Maydell <peter.maydell@linaro.org> writes: > In allwinner_sdhost_process_desc() we just read directly from > guest memory into a host TransferDescriptor struct and back. > This only works on little-endian hosts. Abstract the reading > and writing of descriptors into functions that handle the > byte-swapping so that TransferDescriptor structs as seen by > the rest of the code are always in host-order. I couldn't find any datasheets on the sdhost hardware but the kernel certainly explicitly sets the endianess of the descriptors so: Reviewed-by: Alex Bennée <alex.bennee@linaro.org> -- Alex Bennée Virtualisation Tech Lead @ Linaro
[Prev in Thread] | Current Thread | [Next in Thread] |