Re: [PATCH 1/2] target/arm: Define and use new load_cpu_field

qemu-devel

Re: [PATCH 1/2] target/arm: Define and use new load_cpu_field_low32()

From:	Richard Henderson
Subject:	Re: [PATCH 1/2] target/arm: Define and use new load_cpu_field_low32()
Date:	Mon, 24 Apr 2023 17:14:35 +0100
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 4/24/23 16:39, Peter Maydell wrote:

+        QEMU_BUILD_BUG_ON(sizeof(typeof_field(CPUARMState, name)) != 8); \


Surely just sizeof_field().

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

Current Thread

[Next in Thread]

[PATCH 0/2] target/arm: Load correct half of 64-bit fields, Peter Maydell, 2023/04/24
- [PATCH 2/2] target/arm: Add compile time asserts to load/store_cpu_field macros, Peter Maydell, 2023/04/24
  - Re: [PATCH 2/2] target/arm: Add compile time asserts to load/store_cpu_field macros, Richard Henderson, 2023/04/24
- [PATCH 1/2] target/arm: Define and use new load_cpu_field_low32(), Peter Maydell, 2023/04/24
  - Re: [PATCH 1/2] target/arm: Define and use new load_cpu_field_low32(), Richard Henderson <=