Re: [RFC PATCH v3 41/44] target/loongarch: Implement vld vst

[Richard Henderson]

On 4/20/23 09:07, Song Gao wrote:
> +#include "tcg/tcg-internal.h"

This is internal to tcg.  Do not use.

> +    tcg_gen_qemu_ld_i128(val, addr, ctx->mem_idx, MO_128);
> +    set_vreg64(TCGV128_HIGH(val), a->vd, 1);
> +    set_vreg64(TCGV128_LOW(val), a->vd, 0);

You want tcg_gen_extr_i128_i64().

> +    tcg_gen_mov_i64(TCGV128_LOW(val), al);
> +    tcg_gen_mov_i64(TCGV128_HIGH(val), ah);
> +    tcg_gen_qemu_st_i128(val, addr, ctx->mem_idx, MO_128);

tcg_gen_concat_i64_i128().

> +++ b/target/loongarch/lsx_helper.c
> @@ -12,6 +12,7 @@
>  #include "fpu/softfloat.h"
>  #include "internals.h"
>  #include "tcg/tcg.h"
> +#include "tcg/tcg-ldst.h"

Do not use.  Use "exec/cpu_ldst.h".


r~