qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] accel/tcg/tcg-accel-ops-rr: ensure fairness with icount


From: Richard Henderson
Subject: Re: [PATCH v2] accel/tcg/tcg-accel-ops-rr: ensure fairness with icount
Date: Mon, 24 Apr 2023 14:26:46 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 4/24/23 14:21, Jamie Iles wrote:
Why cpu_budget = INT64_MAX as opposed to 0 or 0xdeadbeef?  It's not set or used 
except for
icount_enabled.

That's left over from an earlier version, I can leave it uninitialized.

No, you can't, as you'll get a compiler warning, because the compiler won't see that the conditional init matches the conditional use.

A zero init value would only need comment for the conditional init/use. A non-zero init value without comment is magic and bad for maintenance.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]