[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 4/5] parallels: Replace fprintf by qemu_log in check
From: |
Alexander Ivanov |
Subject: |
[PATCH v4 4/5] parallels: Replace fprintf by qemu_log in check |
Date: |
Mon, 24 Apr 2023 11:43:08 +0200 |
If the check is called during normal work, tracking of the check must be
present in VM logs to have some clues if something going wrong with user's
data.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
---
block/parallels.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index 3b992e8173..5dc56ca36b 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -42,6 +42,7 @@
#include "qemu/bswap.h"
#include "qemu/bitmap.h"
#include "qemu/memalign.h"
+#include "qemu/log-for-trace.h"
#include "migration/blocker.h"
#include "parallels.h"
@@ -436,8 +437,8 @@ static void parallels_check_unclean(BlockDriverState *bs,
return;
}
- fprintf(stderr, "%s image was not closed correctly\n",
- fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR");
+ qemu_log("%s image was not closed correctly\n",
+ fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR");
res->corruptions++;
if (fix & BDRV_FIX_ERRORS) {
/* parallels_close will do the job right */
@@ -464,8 +465,8 @@ parallels_check_outside_image(BlockDriverState *bs,
BdrvCheckResult *res,
for (i = 0; i < s->bat_size; i++) {
off = bat2sect(s, i) << BDRV_SECTOR_BITS;
if (off + s->cluster_size > size) {
- fprintf(stderr, "%s cluster %u is outside image\n",
- fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR", i);
+ qemu_log("%s cluster %u is outside image\n",
+ fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR", i);
res->corruptions++;
if (fix & BDRV_FIX_ERRORS) {
parallels_set_bat_entry(s, i, 0);
@@ -551,8 +552,8 @@ parallels_check_leak(BlockDriverState *bs, BdrvCheckResult
*res,
count = DIV_ROUND_UP(leak_size, s->cluster_size);
res->leaks += count;
- fprintf(stderr, "%s space leaked at the end of the image %" PRId64 "\n",
- fix & BDRV_FIX_LEAKS ? "Repairing" : "ERROR", leak_size);
+ qemu_log("%s space leaked at the end of the image %" PRId64 "\n",
+ fix & BDRV_FIX_LEAKS ? "Repairing" : "ERROR", leak_size);
if (fix & BDRV_FIX_LEAKS) {
res->leaks_fixed += count;
@@ -599,9 +600,8 @@ static int parallels_check_duplicate(BlockDriverState *bs,
cluster_index = host_cluster_index(s, off);
if (test_bit(cluster_index, bitmap)) {
/* this cluster duplicates another one */
- fprintf(stderr,
- "%s duplicate offset in BAT entry %u\n",
- *fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR", i);
+ qemu_log("%s duplicate offset in BAT entry %u\n",
+ *fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR", i);
res->corruptions++;
--
2.34.1
- [PATCH v4 0/5] parallels: Add duplication check, repair at open, fix bugs, Alexander Ivanov, 2023/04/24
- [PATCH v4 1/5] parallels: Incorrect data end calculation in parallels_open(), Alexander Ivanov, 2023/04/24
- [PATCH v4 2/5] parallels: Split image leak handling to separate check and fix helpers, Alexander Ivanov, 2023/04/24
- [PATCH v4 4/5] parallels: Replace fprintf by qemu_log in check,
Alexander Ivanov <=
- [PATCH v4 5/5] parallels: Image repairing in parallels_open(), Alexander Ivanov, 2023/04/24