Re: [PATCH 2/3] block: do not check bdrv_file_open

[Paolo Bonzini]

On Thu, Jan 19, 2023 at 2:17 PM Kevin Wolf <kwolf@redhat.com> wrote:
> >      assert(!drv->bdrv_needs_filename || bs->filename[0]);
> > -    if (drv->bdrv_file_open) {
> > +    if (drv->bdrv_open) {
> >          ret = drv->bdrv_file_open(bs, options, open_flags, &local_err);
> >      } else if (drv->bdrv_open) {
> >          ret = drv->bdrv_open(bs, options, open_flags, &local_err);
>
> I suppose you mean drv->protocol_name for the first if condition?
>
> The bug will disappear again after patch 3, but this intermediate state
> is very broken.

Yep, I split the patch wrong. Will resend after you merge block-next.

Paolo