[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 21/43] migration: Create migrate_throttle_trigger_threshol
From: |
Fabiano Rosas |
Subject: |
Re: [PATCH v2 21/43] migration: Create migrate_throttle_trigger_threshold() |
Date: |
Thu, 20 Apr 2023 15:47:43 -0300 |
Juan Quintela <quintela@redhat.com> writes:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> migration/options.c | 9 +++++++++
> migration/options.h | 1 +
> migration/ram.c | 3 +--
> 3 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/migration/options.c b/migration/options.c
> index 2b6d88b4b9..b9f3815f7e 100644
> --- a/migration/options.c
> +++ b/migration/options.c
> @@ -554,6 +554,15 @@ int migrate_multifd_zstd_level(void)
> return s->parameters.multifd_zstd_level;
> }
>
> +uint8_t migrate_throttle_trigger_threshold(void)
> +{
> + MigrationState *s;
> +
> + s = migrate_get_current();
> +
> + return s->parameters.throttle_trigger_threshold;
> +}
> +
> uint64_t migrate_xbzrle_cache_size(void)
> {
> MigrationState *s;
> diff --git a/migration/options.h b/migration/options.h
> index 96d5a8e6e4..aa54443353 100644
> --- a/migration/options.h
> +++ b/migration/options.h
> @@ -55,6 +55,7 @@ int migrate_multifd_channels(void);
> MultiFDCompression migrate_multifd_compression(void);
> int migrate_multifd_zlib_level(void);
> int migrate_multifd_zstd_level(void);
> +uint8_t migrate_throttle_trigger_threshold(void);
> uint64_t migrate_xbzrle_cache_size(void);
>
> #endif
> diff --git a/migration/ram.c b/migration/ram.c
> index 7f28588dde..68801012ba 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -1179,8 +1179,7 @@ static void migration_update_rates(RAMState *rs,
> int64_t end_time)
>
> static void migration_trigger_throttle(RAMState *rs)
> {
> - MigrationState *s = migrate_get_current();
> - uint64_t threshold = s->parameters.throttle_trigger_threshold;
> + uint64_t threshold = migrate_throttle_trigger_threshold();
> uint64_t bytes_xfer_period =
> stat64_get(&ram_counters.transferred) - rs->bytes_xfer_prev;
> uint64_t bytes_dirty_period = rs->num_dirty_pages_period *
> TARGET_PAGE_SIZE;
Reviewed-by: Fabiano Rosas <farosas@suse.de>
- Re: [PATCH v2 16/43] migration: Move qmp_migrate_set_capabilities() to options.c, (continued)
- [PATCH v2 17/43] migration: Move migrate_cap_set() to options.c, Juan Quintela, 2023/04/20
- [PATCH v2 18/43] migration: Move parameters functions to option.c, Juan Quintela, 2023/04/20
- [PATCH v2 19/43] migration: Use migrate_max_postcopy_bandwidth(), Juan Quintela, 2023/04/20
- [PATCH v2 20/43] migration: Move migrate_use_block_incremental() to option.c, Juan Quintela, 2023/04/20
- [PATCH v2 21/43] migration: Create migrate_throttle_trigger_threshold(), Juan Quintela, 2023/04/20
- Re: [PATCH v2 21/43] migration: Create migrate_throttle_trigger_threshold(),
Fabiano Rosas <=
- [PATCH v2 22/43] migration: Create migrate_checkpoint_delay(), Juan Quintela, 2023/04/20
- [PATCH v2 24/43] migration: Move migrate_announce_params() to option.c, Juan Quintela, 2023/04/20
- [PATCH v2 23/43] migration: Create migrate_max_cpu_throttle(), Juan Quintela, 2023/04/20
- [PATCH v2 29/43] migration: Move migrate_postcopy() to options.c, Juan Quintela, 2023/04/20
- [PATCH v2 26/43] migration: Create migrate_cpu_throttle_increment() function, Juan Quintela, 2023/04/20