Re: [PATCH v2 2/4] scripts/qapi: allow optional experimental enum values

[Eric Blake]

On Thu, Apr 20, 2023 at 01:52:30AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> To be used in the next commit.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>  scripts/qapi/types.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/qapi/types.py b/scripts/qapi/types.py
> index c39d054d2c..18f8734047 100644
> --- a/scripts/qapi/types.py
> +++ b/scripts/qapi/types.py
> @@ -61,10 +61,12 @@ def gen_enum_lookup(name: str,
>  
>          special_features = gen_special_features(memb.features)
>          if special_features != '0':
> +            feats += memb.ifcond.gen_if()
>              feats += mcgen('''
>          [%(index)s] = %(special_features)s,
>  ''',
>                             index=index, special_features=special_features)
> +            feats += memb.ifcond.gen_endif()

Perhaps Markus will have a comment here; but in general, changes to
the QAPI that don't have accompanying changes in the testsuite are
hard to prove that they do something useful.

At a minimum, the commit message should at least say what sort of
things are not permitted without this patch that are now possible,
rather than making me figure out what the next patch uses that failed
the QAPI generator without this patch.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org