Re: [PATCH 06/43] migration: Move migrate_use_compression() to options.c

[Juan Quintela]

Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:
> On 02.03.23 19:33, Juan Quintela wrote:
>> Once that we are there, we rename the function to migrate_compress()
>> to be consistent with all other capabilities.
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
>
>> ---
>>   migration/migration.h |  1 -
>>   migration/options.h   |  1 +
>>   migration/migration.c | 11 +----------
>>   migration/options.c   |  9 +++++++++
>
> [..]
>
>> --- a/migration/options.c
>> +++ b/migration/options.c
>> @@ -41,6 +41,15 @@ bool migrate_colo(void)
>>       return s->capabilities[MIGRATION_CAPABILITY_X_COLO];
>>   }
>>   +bool migrate_compress(void)
>> +{
>> +    MigrationState *s;
>> +
>> +    s = migrate_get_current();
>> +
>> +    return s->capabilities[MIGRATION_CAPABILITY_COMPRESS];
>> +}
>
> Probably, we could generate these functions automatically, or at least
> have a helper, so that all such functions are one-line wrappers on
> that helper.

Markus, or any other qapi guru, I would be happy if this could be
managed automagically O:-)

Later, Juan.