[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 11/20] migration: Make dirty_pages_rate atomic
From: |
Juan Quintela |
Subject: |
[PULL 11/20] migration: Make dirty_pages_rate atomic |
Date: |
Thu, 20 Apr 2023 15:17:42 +0200 |
In this case we use qatomic operations instead of Stat64 wrapper
because there is no stat64_set(). Defining the 64 bit wrapper is
trivial. The one without atomics is more interesting.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
---
migration/migration.c | 6 ++++--
migration/ram.c | 5 +++--
migration/ram.h | 2 +-
3 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 09b37a6603..50eae2fbcd 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1190,7 +1190,8 @@ static void populate_ram_info(MigrationInfo *info,
MigrationState *s)
if (s->state != MIGRATION_STATUS_COMPLETED) {
info->ram->remaining = ram_bytes_remaining();
- info->ram->dirty_pages_rate = ram_counters.dirty_pages_rate;
+ info->ram->dirty_pages_rate =
+ qatomic_read__nocheck(&ram_counters.dirty_pages_rate);
}
}
@@ -3844,7 +3845,8 @@ static void migration_update_counters(MigrationState *s,
* if we haven't sent anything, we don't want to
* recalculate. 10000 is a small enough number for our purposes
*/
- if (ram_counters.dirty_pages_rate && transferred > 10000) {
+ if (qatomic_read__nocheck(&ram_counters.dirty_pages_rate) &&
+ transferred > 10000) {
s->expected_downtime = ram_counters.remaining / bandwidth;
}
diff --git a/migration/ram.c b/migration/ram.c
index fe69ecaef4..7400abf5e1 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1129,8 +1129,9 @@ static void migration_update_rates(RAMState *rs, int64_t
end_time)
double compressed_size;
/* calculate period counters */
- ram_counters.dirty_pages_rate = rs->num_dirty_pages_period * 1000
- / (end_time - rs->time_last_bitmap_sync);
+ qatomic_set__nocheck(&ram_counters.dirty_pages_rate,
+ rs->num_dirty_pages_period * 1000 /
+ (end_time - rs->time_last_bitmap_sync));
if (!page_count) {
return;
diff --git a/migration/ram.h b/migration/ram.h
index afa68521d7..574a604b72 100644
--- a/migration/ram.h
+++ b/migration/ram.h
@@ -41,7 +41,7 @@
* one thread).
*/
typedef struct {
- int64_t dirty_pages_rate;
+ aligned_uint64_t dirty_pages_rate;
Stat64 dirty_sync_count;
Stat64 dirty_sync_missed_zero_copy;
Stat64 downtime_bytes;
--
2.39.2
- [PULL 00/20] Migration 20230420 patches, Juan Quintela, 2023/04/20
- [PULL 01/20] migration: remove extra whitespace character for code style, Juan Quintela, 2023/04/20
- [PULL 09/20] migration: Make dirty_sync_count atomic, Juan Quintela, 2023/04/20
- [PULL 12/20] migration: Make dirty_bytes_last_sync atomic, Juan Quintela, 2023/04/20
- [PULL 06/20] migration: Make dirty_sync_missed_zero_copy atomic, Juan Quintela, 2023/04/20
- [PULL 11/20] migration: Make dirty_pages_rate atomic,
Juan Quintela <=
- [PULL 04/20] migration: Update atomic stats out of the mutex, Juan Quintela, 2023/04/20
- [PULL 03/20] migration: Merge ram_counters and ram_atomic_counters, Juan Quintela, 2023/04/20
- [PULL 05/20] migration: Make multifd_bytes atomic, Juan Quintela, 2023/04/20
- [PULL 07/20] migration: Make precopy_bytes atomic, Juan Quintela, 2023/04/20
- [PULL 13/20] migration: Rename duplicate to zero_pages, Juan Quintela, 2023/04/20
- [PULL 08/20] migration: Make downtime_bytes atomic, Juan Quintela, 2023/04/20
- [PULL 16/20] util/mmap-alloc: qemu_fd_getfs(), Juan Quintela, 2023/04/20
- [PULL 17/20] vl.c: Create late backends before migration object, Juan Quintela, 2023/04/20
- [PULL 18/20] migration/postcopy: Detect file system on dest host, Juan Quintela, 2023/04/20
- [PULL 19/20] migration: rename enabled_capabilities to capabilities, Juan Quintela, 2023/04/20