[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] tests/qtest: capture RESUME events during migration
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 1/2] tests/qtest: capture RESUME events during migration |
Date: |
Thu, 20 Apr 2023 12:37:07 +0100 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Thu, Apr 20, 2023 at 01:32:37PM +0200, Juan Quintela wrote:
> Daniel P. Berrangé <berrange@redhat.com> wrote:
> > When running migration tests we monitor for a STOP event so we can skip
> > redundant waits. This will be needed for the RESUME event too shortly.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>
>
> I am waiting for you to check the problem than Lukas detected, but this
> part of the patch is "obviously" correct.
>
> Famous last words.
Actually it has a small flaw - I don't set 'got_resume = false' at the
start of each test :-(
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|